You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2018/08/10 18:11:20 UTC
Review Request 68300: Added `gpus` to failure message.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68300/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jason Lai.
Repository: mesos
Description
-------
This message would be propagated all the way to scheduler, so making it
explicit that this is related to gpu can speed up debugging.
Diffs
-----
src/slave/containerizer/mesos/isolators/gpu/allocator.cpp c288ad634b856702483b9751f41445308babd0c9
Diff: https://reviews.apache.org/r/68300/diff/1/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 68300: Added `gpus` to failure message.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68300/#review207083
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Aug. 10, 2018, 11:11 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68300/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2018, 11:11 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This message would be propagated all the way to scheduler, so making it
> explicit that this is related to gpu can speed up debugging.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/gpu/allocator.cpp c288ad634b856702483b9751f41445308babd0c9
>
>
> Diff: https://reviews.apache.org/r/68300/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 68300: Added `gpus` to failure message.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68300/#review207089
-----------------------------------------------------------
PASS: Mesos patch 68300 was successfully built and tested.
Reviews applied: `['68300']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2129/mesos-review-68300
- Mesos Reviewbot Windows
On Aug. 10, 2018, 11:11 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68300/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2018, 11:11 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This message would be propagated all the way to scheduler, so making it
> explicit that this is related to gpu can speed up debugging.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/gpu/allocator.cpp c288ad634b856702483b9751f41445308babd0c9
>
>
> Diff: https://reviews.apache.org/r/68300/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>