You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/10/30 07:46:35 UTC
[GitHub] [flink] KurtYoung commented on a change in pull request #9994:
[FLINK-14322][table-api] Add watermark information in TableSchema
KurtYoung commented on a change in pull request #9994: [FLINK-14322][table-api] Add watermark information in TableSchema
URL: https://github.com/apache/flink/pull/9994#discussion_r340460315
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java
##########
@@ -54,44 +58,70 @@
private final DataType[] fieldDataTypes;
- private final Map<String, Integer> fieldNameToIndex;
+ /** Mapping from qualified field name to (nested) field type. */
+ private final Map<String, DataType> typesByName;
- private TableSchema(String[] fieldNames, DataType[] fieldDataTypes) {
+ private final List<WatermarkSpec> watermarkSpecs;
+
+ private TableSchema(String[] fieldNames, DataType[] fieldDataTypes, List<WatermarkSpec> watermarkSpecs) {
this.fieldNames = Preconditions.checkNotNull(fieldNames);
this.fieldDataTypes = Preconditions.checkNotNull(fieldDataTypes);
+ this.watermarkSpecs = Preconditions.checkNotNull(watermarkSpecs);
if (fieldNames.length != fieldDataTypes.length) {
- throw new TableException(
+ throw new ValidationException(
Review comment:
we can move such sanity check to `Builder`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services