You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2023/08/09 01:19:29 UTC

Change in asterixdb[master]: [NO ISSUE][OTH] Check folder exists when loading a directory

From Wail Alkowaileet <wa...@gmail.com>:

Wail Alkowaileet has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17710 )


Change subject: [NO ISSUE][OTH] Check folder exists when loading a directory
......................................................................

[NO ISSUE][OTH] Check folder exists when loading a directory

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
When loading a directory to S3Mock, check if the directory
already exists.

Change-Id: I8709370239d39512c87d94b3232e773275887ccf
---
M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/ExternalDatasetTestUtils.java
1 file changed, 23 insertions(+), 1 deletion(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/10/17710/1

diff --git a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/ExternalDatasetTestUtils.java b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/ExternalDatasetTestUtils.java
index b50c353..7da2334 100644
--- a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/ExternalDatasetTestUtils.java
+++ b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/ExternalDatasetTestUtils.java
@@ -283,7 +283,12 @@
     }
 
     private static void loadDirectory(String dataBasePath, String rootPath, FilenameFilter filter) {
-        Collection<File> files = IoUtil.getMatchingFiles(Path.of(dataBasePath, rootPath), filter);
+        File dir = new File(dataBasePath, rootPath);
+        if (!dir.exists() || !dir.isDirectory()) {
+            return;
+        }
+
+        Collection<File> files = IoUtil.getMatchingFiles(dir.toPath(), filter);
         int size = 0;
         for (File file : files) {
             String path = file.getPath();

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17710
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I8709370239d39512c87d94b3232e773275887ccf
Gerrit-Change-Number: 17710
Gerrit-PatchSet: 1
Gerrit-Owner: Wail Alkowaileet <wa...@gmail.com>
Gerrit-MessageType: newchange