[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #4706: feat: set project mapping by plugin org

["warren830 (via GitHub)" <gi...@apache.org>]

warren830 commented on code in PR #4706:
URL: https://github.com/apache/incubator-devlake/pull/4706#discussion_r1142872801


##########
backend/core/dal/dal.go:
##########
@@ -239,7 +240,8 @@ func GetPrimarykeyColumnNames(d Dal, dst Tabler) (names []string, err errors.Err
 		return
 	}
 	for _, pkColumn := range pkColumns {
-		names = append(names, pkColumn.Name())
+		// in case the column name is a reserved identifier
+		names = append(names, fmt.Sprintf("%s.%s", dst.TableName(), pkColumn.Name()))

Review Comment:
   not clear about this, why do we need to add tableName as prefix?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org