You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2024/09/16 10:14:15 UTC

[PR] [FLINK-36279][runtime] Making desired resources being calculated based on all available slots for the job [flink]

XComp opened a new pull request, #25341:
URL: https://github.com/apache/flink/pull/25341

   ## What is the purpose of the change
   
   FLINK-36014 aligned the triggering of the `CreateExecutionGraph` state within `WaitingForResources` and `Executing` state. Before that change, only `WaitingForResources` relied on this method. Relying on free slots was good enough because in `WaitingForResources` state, there are no slots allocated, yet.
       
   Using this method for `Executing` state now as well changes this premise because there are slots allocated while checking the slot availability that would become available after the restart. Hence, considering these slots in the slot availability check is good enough. This will not break the premise for the `WaitingForResources` state.
   
   ## Brief change log
   
   * Make the `hasDesiredResources` check rely on all available slots rather than only the free slots.
   
   ## Verifying this change
   
   * `RescaleOnCheckpointITCase` succeeds again
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36279][runtime] Making desired resources being calculated based on all available slots for the job [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25341:
URL: https://github.com/apache/flink/pull/25341#issuecomment-2352567696

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cc517ad64bbcfc2fd58e414a8016a29420e20693",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cc517ad64bbcfc2fd58e414a8016a29420e20693",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cc517ad64bbcfc2fd58e414a8016a29420e20693 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36279][runtime] Making desired resources being calculated based on all available slots for the job [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #25341:
URL: https://github.com/apache/flink/pull/25341


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org