You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Fred Allard (JIRA)" <de...@myfaces.apache.org> on 2008/08/29 01:19:44 UTC
[jira] Created: (MYFACES-1944) Implement JSF 2.0 logic at TODO #13
Implement JSF 2.0 logic at TODO #13
-----------------------------------
Key: MYFACES-1944
URL: https://issues.apache.org/jira/browse/MYFACES-1944
Project: MyFaces Core
Issue Type: Task
Components: JSR-314
Affects Versions: 2.0.0-alpha
Reporter: Fred Allard
Priority: Minor
In class: javax.faces.component.UIComponent
Implement: protected void popComponentFromEL(FacesContext context)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1944) Implement JSF 2.0 logic at TODO
#13
Posted by "Marc De Lafontaine (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641995#action_12641995 ]
Marc De Lafontaine commented on MYFACES-1944:
---------------------------------------------
I'm on it
> Implement JSF 2.0 logic at TODO #13
> -----------------------------------
>
> Key: MYFACES-1944
> URL: https://issues.apache.org/jira/browse/MYFACES-1944
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Affects Versions: 2.0.0-alpha
> Reporter: Fred Allard
> Priority: Minor
> Attachments: MYFACES-1944.patch
>
>
> In class: javax.faces.component.UIComponent
> Implement: protected void popComponentFromEL(FacesContext context)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1944) Implement JSF 2.0 logic at TODO #13
Posted by "Marc De Lafontaine (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marc De Lafontaine updated MYFACES-1944:
----------------------------------------
Status: Patch Available (was: Open)
> Implement JSF 2.0 logic at TODO #13
> -----------------------------------
>
> Key: MYFACES-1944
> URL: https://issues.apache.org/jira/browse/MYFACES-1944
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Affects Versions: 2.0.0-alpha
> Reporter: Fred Allard
> Priority: Minor
> Attachments: MYFACES-1944.patch
>
>
> In class: javax.faces.component.UIComponent
> Implement: protected void popComponentFromEL(FacesContext context)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1944) Implement JSF 2.0 logic at TODO
#13
Posted by "Simon Lessard (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647094#action_12647094 ]
Simon Lessard commented on MYFACES-1944:
----------------------------------------
Such solution could be investigated, it would surely be very efficient, but it would also be extremely dependent on the fact that pop would be called on the same component instance and I'm not sure that it's always the case.
There are some weird pushes for which I didn't find the pop yet so I would keep a stack collection for now, but we should certainly reevaluate the private variable option once we're more comfortable with the 2.0 spec and can identify pops for every pushes.
> Implement JSF 2.0 logic at TODO #13
> -----------------------------------
>
> Key: MYFACES-1944
> URL: https://issues.apache.org/jira/browse/MYFACES-1944
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Affects Versions: 2.0.0-alpha
> Reporter: Fred Allard
> Priority: Minor
> Attachments: MYFACES-1944.patch
>
>
> In class: javax.faces.component.UIComponent
> Implement: protected void popComponentFromEL(FacesContext context)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1944) Implement JSF 2.0 logic at TODO
#13
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644546#action_12644546 ]
Leonardo Uribe commented on MYFACES-1944:
-----------------------------------------
Maybe use just a private variable on UIComponent is enough. popComponentFromEL and pushComponentFromEL are used on several methods that traverse the component tree and always are used in pairs without callings to different methods that use them, so the easiest place to hold this value are inside the component tree (when the method ends always the value of this private var is null if in popComponentFromEL has proper code to do that).
> Implement JSF 2.0 logic at TODO #13
> -----------------------------------
>
> Key: MYFACES-1944
> URL: https://issues.apache.org/jira/browse/MYFACES-1944
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Affects Versions: 2.0.0-alpha
> Reporter: Fred Allard
> Priority: Minor
> Attachments: MYFACES-1944.patch
>
>
> In class: javax.faces.component.UIComponent
> Implement: protected void popComponentFromEL(FacesContext context)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1944) Implement JSF 2.0 logic at TODO #13
Posted by "Marc De Lafontaine (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marc De Lafontaine updated MYFACES-1944:
----------------------------------------
Status: Patch Available (was: Open)
> Implement JSF 2.0 logic at TODO #13
> -----------------------------------
>
> Key: MYFACES-1944
> URL: https://issues.apache.org/jira/browse/MYFACES-1944
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Affects Versions: 2.0.0-alpha
> Reporter: Fred Allard
> Priority: Minor
> Attachments: MYFACES-1944.patch
>
>
> In class: javax.faces.component.UIComponent
> Implement: protected void popComponentFromEL(FacesContext context)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1944) Implement JSF 2.0 logic at TODO #13
Posted by "Simon Lessard (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Lessard updated MYFACES-1944:
-----------------------------------
Status: Open (was: Patch Available)
> Implement JSF 2.0 logic at TODO #13
> -----------------------------------
>
> Key: MYFACES-1944
> URL: https://issues.apache.org/jira/browse/MYFACES-1944
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Affects Versions: 2.0.0-alpha
> Reporter: Fred Allard
> Priority: Minor
> Attachments: MYFACES-1944.patch
>
>
> In class: javax.faces.component.UIComponent
> Implement: protected void popComponentFromEL(FacesContext context)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1944) Implement JSF 2.0 logic at TODO
#13
Posted by "Simon Lessard (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642001#action_12642001 ]
Simon Lessard commented on MYFACES-1944:
----------------------------------------
Hi, don't use Concurrent collection for push/pop as the FacesContext is always thread safe. Also, you don't need a class member in UIComponent to resolve that issue. Please correct the patch accordingly. Thanks.
~ Simon
> Implement JSF 2.0 logic at TODO #13
> -----------------------------------
>
> Key: MYFACES-1944
> URL: https://issues.apache.org/jira/browse/MYFACES-1944
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Affects Versions: 2.0.0-alpha
> Reporter: Fred Allard
> Priority: Minor
> Attachments: MYFACES-1944.patch
>
>
> In class: javax.faces.component.UIComponent
> Implement: protected void popComponentFromEL(FacesContext context)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1944) Implement JSF 2.0 logic at TODO #13
Posted by "Simon Lessard (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Lessard updated MYFACES-1944:
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0-alpha
Status: Resolved (was: Patch Available)
Applied patch to the branch, revision 713546, thank you.
> Implement JSF 2.0 logic at TODO #13
> -----------------------------------
>
> Key: MYFACES-1944
> URL: https://issues.apache.org/jira/browse/MYFACES-1944
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Affects Versions: 2.0.0-alpha
> Reporter: Fred Allard
> Assignee: Simon Lessard
> Priority: Minor
> Fix For: 2.0.0-alpha
>
> Attachments: MYFACES-1944.patch
>
>
> In class: javax.faces.component.UIComponent
> Implement: protected void popComponentFromEL(FacesContext context)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.