You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2020/02/03 10:16:52 UTC
[GitHub] [dubbo-go] codecov-io commented on issue #348: Mod:refactor
to add base_registry
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/348?src=pr&el=h1) Report
> Merging [#348](https://codecov.io/gh/apache/dubbo-go/pull/348?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/d654f3ad441216007adea453ee4bc7c5592d3d25?src=pr&el=desc) will **increase** coverage by `0.75%`.
> The diff coverage is `79.54%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/348/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/348?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #348 +/- ##
===========================================
+ Coverage 66.89% 67.65% +0.75%
===========================================
Files 123 123
Lines 7628 7317 -311
===========================================
- Hits 5103 4950 -153
+ Misses 2030 1894 -136
+ Partials 495 473 -22
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/348?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/zookeeper/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/348/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2ZhY2FkZS5nbw==) | `74.28% <0%> (ø)` | :arrow_up: |
| [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/348/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0% <0%> (ø)` | :arrow_up: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/348/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `73.13% <100%> (+21.61%)` | :arrow_up: |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/348/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | `40% <100%> (ø)` | :arrow_up: |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/348/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <50%> (ø)` | :arrow_up: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/348/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `60.86% <66.66%> (ø)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/348/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.55% <88.23%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/348?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/348?src=pr&el=footer). Last update [d654f3a...af4683c](https://codecov.io/gh/apache/dubbo-go/pull/348?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/348 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org