You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Patrick0308 (GitHub)" <gi...@apache.org> on 2020/02/23 04:01:21 UTC
[GitHub] [dubbo-go] Patrick0308 opened pull request #370: Fix Rest
protocol
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
[ Full content available at: https://github.com/apache/dubbo-go/pull/370 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed pull request #370: Fix Rest
protocol
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
[ pull request closed by AlexStocks ]
[ Full content available at: https://github.com/apache/dubbo-go/pull/370 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #370: Fix Rest
protocol
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/370?src=pr&el=h1) Report
> Merging [#370](https://codecov.io/gh/apache/dubbo-go/pull/370?src=pr&el=desc) into [feature/rest](https://codecov.io/gh/apache/dubbo-go/commit/b8ac514189ea4f0d2807a1c3f39fe0e4ea97d914?src=pr&el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/370/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/370?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/rest #370 +/- ##
===============================================
+ Coverage 66.75% 66.9% +0.14%
===============================================
Files 158 158
Lines 8230 8230
===============================================
+ Hits 5494 5506 +12
+ Misses 2210 2200 -10
+ Partials 526 524 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/370?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/370/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `57.26% <0%> (+1.7%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/370/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0%> (+2.15%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/370/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `62.5% <0%> (+25%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/370?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/370?src=pr&el=footer). Last update [b8ac514...c8a5d15](https://codecov.io/gh/apache/dubbo-go/pull/370?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/370 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org