[jira] Commented: (ESME-321) Get rid of deprecated methods

["Vladimir Ivanov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ESME-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977865#action_12977865 ] 

Vladimir Ivanov commented on ESME-321:
--------------------------------------

I've added first version of patch related to getting rid of deprecation warnings. I have some questions regarding remaining deprecated methods:

1) Method List.sort() is deprecated and Scala compiler suggests to use SeqLike.sortWith() instead. I replaced this method by new version in PopStatsActor:95. Now corresponding test spec PopStatsActorSpecs is failing with two errors:

[error] x Popularity Stats should
[error]   x Update top hits after inrcementing statistics
[error]     'List((1,1), (3,1))' is not equal to 'List((3,1), (1,1))' (PopStatsActorTest.scala:44)
[error]   x Information should expire after timeout
[error]     'List((3,1))' is not equal to 'List()' (PopStatsActorTest.scala:54)

Other tests passed.

2) Method Either.merge() used in TwitterAPI: 390 is deprecated. I suppose that this method will be replaced by MergeableEither.merge() via implicit either2mergeable() conversion method. Please correct me if I'm wrong.
3) We have case class FetchFeed with two subclasses FetchAtom and FetchRss. Scala compiler calls it unduly implementation and suggests using Extractor object instead, but I don't know whether it is simpler solution...
4) Object Log is deprecated in Lift 2.2. How do you think if it's correct to mixin with Loggable trait and use default logger val?

> Get rid of deprecated methods
> -----------------------------
>
>                 Key: ESME-321
>                 URL: https://issues.apache.org/jira/browse/ESME-321
>             Project: ESME
>          Issue Type: Task
>          Components: Server
>    Affects Versions: 1.2
>            Reporter: Vladimir Ivanov
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: depr.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Compiler issues multiple warnings related to usage of methods that have been deprecated in Lift 2.2 and Scala 2.8.1. Very likely these methods will be removed in future Lift and Scala versions, so it would be better to use new methods instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.