Missing commit diffs (was: elastic.py#scan_and_scroll - why default size = 1?)

[sebb <se...@gmail.com>]

On Fri, 26 Apr 2019 at 00:34, Daniel Gruno <hu...@apache.org> wrote:
>
> On 25/04/2019 18.20, sebb wrote:
> > The default scroll size of 10 has been overridden as 1 in the initial commit:
>
> Good catch! I was testing with 1 to see it go through iterations, must
> have forgotten to revert that. It should be 100.

OK, I have seen the updated commit diff.

Note that the original commit diff does not appear to have been sent
to the commits@ list.
This is why I had to provide the URL below.

AFAIK all my commits have shown up as diffs on the commits list, so I
wonder why some of yours have not?

It makes it hard to operate CTR if there is no C to R!
Is there anything you can do to ensure all commit diffs are published?

> >
> > https://gitbox.apache.org/repos/asf?p=incubator-ponymail.git;a=commitdiff;h=79c97118b6a73336e910897693fd71ba92f1dab1
> >
> > Why is that?
> >
>

Re: Missing commit diffs

[sebb <se...@gmail.com>]

On Fri, 26 Apr 2019 at 01:18, Daniel Gruno <hu...@apache.org> wrote:
>
> On 25/04/2019 19.08, sebb wrote:
> > On Fri, 26 Apr 2019 at 00:34, Daniel Gruno <hu...@apache.org> wrote:
> >>
> >> On 25/04/2019 18.20, sebb wrote:
> >>> The default scroll size of 10 has been overridden as 1 in the initial commit:
> >>
> >> Good catch! I was testing with 1 to see it go through iterations, must
> >> have forgotten to revert that. It should be 100.
> >
> > OK, I have seen the updated commit diff.
> >
> > Note that the original commit diff does not appear to have been sent
> > to the commits@ list.
> > This is why I had to provide the URL below.
> >
> > AFAIK all my commits have shown up as diffs on the commits list, so I
> > wonder why some of yours have not?
> >
> > It makes it hard to operate CTR if there is no C to R!
> > Is there anything you can do to ensure all commit diffs are published?
>
> It must be some incompatibility between our gitbox and github that's
> causing this, as I am pushing this to github. I'm not sure what happens,
> but I'll discuss it with the infra team. In the meantime, I can probably
> mitigate this by pushing to gitbox directly instead of github.

Thanks.

FTR: I am currently pushing to gitbox.

> >
> >>>
> >>> https://gitbox.apache.org/repos/asf?p=incubator-ponymail.git;a=commitdiff;h=79c97118b6a73336e910897693fd71ba92f1dab1
> >>>
> >>> Why is that?
> >>>
> >>
>

Re: Missing commit diffs

[Daniel Gruno <hu...@apache.org>]

On 25/04/2019 19.08, sebb wrote:
> On Fri, 26 Apr 2019 at 00:34, Daniel Gruno <hu...@apache.org> wrote:
>>
>> On 25/04/2019 18.20, sebb wrote:
>>> The default scroll size of 10 has been overridden as 1 in the initial commit:
>>
>> Good catch! I was testing with 1 to see it go through iterations, must
>> have forgotten to revert that. It should be 100.
> 
> OK, I have seen the updated commit diff.
> 
> Note that the original commit diff does not appear to have been sent
> to the commits@ list.
> This is why I had to provide the URL below.
> 
> AFAIK all my commits have shown up as diffs on the commits list, so I
> wonder why some of yours have not?
> 
> It makes it hard to operate CTR if there is no C to R!
> Is there anything you can do to ensure all commit diffs are published?

It must be some incompatibility between our gitbox and github that's 
causing this, as I am pushing this to github. I'm not sure what happens, 
but I'll discuss it with the infra team. In the meantime, I can probably 
mitigate this by pushing to gitbox directly instead of github.

> 
>>>
>>> https://gitbox.apache.org/repos/asf?p=incubator-ponymail.git;a=commitdiff;h=79c97118b6a73336e910897693fd71ba92f1dab1
>>>
>>> Why is that?
>>>
>>