[GitHub] [beam] pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream
URL: https://github.com/apache/beam/pull/10497#discussion_r386714777
 
 

 ##########
 File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
 ##########
 @@ -471,7 +517,14 @@ def process_element(self, element):
     # We can either have the _TestStream or the _WatermarkController to emit
     # the elements. We chose to emit in the _WatermarkController so that the
     # element is emitted at the correct watermark value.
-    for event in self.test_stream.events(self.current_index):
+    events = []
+    if self.watermark == MIN_TIMESTAMP:
 
 Review comment:
   I wonder if we intend this to only be called once - and if it's possible for it to be called more than once.
   In our discussion, it seems that:
   1) It is possible for this to be called more than once - right?
   2) It may be okay for it to be called more htan once.
   
   Let's confirm which of those are true

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services