[jira] [Commented] (METRON-1038) Stellar should have a better collection of basic math operations

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085429#comment-16085429 ] 

ASF GitHub Bot commented on METRON-1038:
----------------------------------------

GitHub user cestella opened a pull request:

    https://github.com/apache/metron/pull/650

    METRON-1038: Stellar should have a better collection of basic math operations

    ## Contributor Comments
    At the moment the math functions are woefully incomplete. 
    We should add at least the ones difficult or impossible to reconstruct using existing stellar primitives/math functions:
    * log10
    * log2
    * ln
    * sqrt
    * ceil
    * floor
    * sin
    * cos
    * tan
    
    It should be sufficient to test these out in the Stellar REPL for manual evaluation.  I have also refactored and added a more robust suite of unit tests for existing basic math functions as well as these new ones.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cestella/incubator-metron METRON-1038

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/650.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #650
    
----
commit 87f1cc99144de3fd6b920c10fbe7e1c1c00d0baf
Author: cstella <ce...@gmail.com>
Date:   2017-07-13T09:06:10Z

    METRON-1038: Stellar should have a better collection of basic math operations

commit ee6c609664f37c7a4fb376431a1bbcd98c08faa2
Author: cstella <ce...@gmail.com>
Date:   2017-07-13T09:21:38Z

    Updating docs

----


> Stellar should have a better collection of basic math operations
> ----------------------------------------------------------------
>
>                 Key: METRON-1038
>                 URL: https://issues.apache.org/jira/browse/METRON-1038
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Casey Stella
>
> At the moment the math functions are woefully incomplete.  
> We should add at least the ones difficult or impossible to reconstruct using existing stellar primitives/math functions:
> * log10
> * log2
> * ln
> * sqrt
> * ceil
> * floor
> * sin
> * cos
> * tan



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)