You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2016/03/17 01:22:33 UTC

[jira] [Updated] (SOLR-8864) TestTestInjection needs to cleanup after itself -- causes TestCloudDeleteByQuery fail (may be symptom of larger problem?)

     [ https://issues.apache.org/jira/browse/SOLR-8864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-8864:
---------------------------
    Attachment: jenkins.log

attaching full jenkins log from https://builds.apache.org/job/Lucene-Solr-Tests-6.x/65/ (branch_6x @ 7687667b5ff7867249762d104707a91834d30ce3) ...

{noformat}
  [junit4]   2> NOTE: test params are: codec=Asserting(Lucene60): {expected_shard_s=FSTOrd50, _version_=FST50,
id=FSTOrd50}, docValues:{}, maxPointsInLeafNode=212, maxMBSortInHeap=5.567883717673721, sim=ClassicSimilarity,
locale=pl, timezone=America/Mendoza
   [junit4]   2> NOTE: Linux 3.13.0-52-generic amd64/Oracle Corporation 1.8.0_66
(64-bit)/cpus=4,threads=1,free=304603432,total=524812288
   [junit4]   2> NOTE: All tests run in this JVM: [ReplicationFactorTest, TestRuleBasedAuthorizationPlugin,
TestSchemaVersionResource, TestSweetSpotSimilarityFactory, SuggesterWFSTTest, TestCharFilters, TestCoreDiscovery,
DirectUpdateHandlerTest, TestConfigOverlay, TestStandardQParsers, GraphQueryTest, StressHdfsTest,
CurrencyFieldXmlFileTest, StatelessScriptUpdateProcessorFactoryTest, TestSolrQueryParserResource, RecoveryZkTest,
TestRecovery, SuggesterTest, TestFastWriter, VMParamsZkACLAndCredentialsProvidersTest,
FieldAnalysisRequestHandlerTest, TestStressReorder, BitVectorTest, DistributedFacetPivotSmallAdvancedTest,
StatsComponentTest, DirectSolrConnectionTest, SolrTestCaseJ4Test, DirectUpdateHandlerOptimizeTest,
TestPivotHelperCode, IgnoreCommitOptimizeUpdateProcessorFactoryTest, FacetPivotSmallTest,
ClassificationUpdateProcessorFactoryTest, SharedFSAutoReplicaFailoverTest, BadIndexSchemaTest,
HLLSerializationTest, TestFuzzyAnalyzedSuggestions, SortSpecParsingTest, HardAutoCommitTest, UpdateParamsTest,
RegexBoostProcessorTest, SliceStateTest, TestSolrQueryParser, TestSchemaNameResource, SolrCloudExampleTest,
TestDocBasedVersionConstraints, TestRebalanceLeaders, TestIndexSearcher, SpatialRPTFieldTypeTest,
TestSimpleQParserPlugin, ConnectionManagerTest, CoreAdminHandlerTest, ZkStateWriterTest, TestExtendedDismaxParser,
TestFieldResource, DeleteLastCustomShardedReplicaTest, TestReqParamsAPI, TestSolrDynamicMBean, BlockCacheTest,
XmlUpdateRequestHandlerTest, TestNamedUpdateProcessors, BinaryUpdateRequestHandlerTest, UnloadDistributedZkTest,
SSLMigrationTest, TestJsonRequest, TestObjectReleaseTracker, LeaderInitiatedRecoveryOnCommitTest,
DebugComponentTest, TestSolrIndexConfig, TestManagedResourceStorage, TestCSVResponseWriter,
TestPostingsSolrHighlighter, SampleTest, TestSolrQueryResponse, HighlighterMaxOffsetTest, TestTestInjection,
HdfsTlogReplayBufferedWhileIndexingTest, TestCloudDeleteByQuery]
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestCloudDeleteByQuery -Dtests.seed=F6D0A21946A344B8
-Dtests.multiplier=2 -Dtests.slow=true -Dtests.locale=pl -Dtests.timezone=America/Mendoza -Dtests.asserts=true
-Dtests.file.encoding=ISO-8859-1
   [junit4] ERROR   0.00s J2 | TestCloudDeleteByQuery (suite) <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: expected:<2> but was:<1>
   [junit4]    >        at __randomizedtesting.SeedInfo.seed([F6D0A21946A344B8]:0)
   [junit4]    >        at
org.apache.solr.cloud.TestCloudDeleteByQuery.createMiniSolrCloudCluster(TestCloudDeleteByQuery.java:173)
   [junit4]    >        at java.lang.Thread.run(Thread.java:745)
   [junit4] Completed [191/581 (1!)] on J2 in 15.37s, 0 tests, 1 failure <<< FAILURES!
{noformat}

FWIW, even when i tried adding this code to TestCloudDeleteByQuery on branch_6x i couldn't get that reproduce line to fail...

{code}
  static {
    // nocommit:
    org.apache.solr.util.TestInjection.failReplicaRequests = "BADSYNTAX";
  }
{code}

[~markrmiller@gmail.com] - can you take a look?



> TestTestInjection needs to cleanup after itself -- causes TestCloudDeleteByQuery fail (may be symptom of larger problem?)
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8864
>                 URL: https://issues.apache.org/jira/browse/SOLR-8864
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>         Attachments: jenkins.log
>
>
> https://builds.apache.org/job/Lucene-Solr-Tests-6.x/65/ recently reported a failure from TestCloudDeleteByQuery's init methods that made no sense to me -- looking at the logs showed an error from "TestInjection.parseValue" even though this test doesn't do anything to setup TestInjection...
> {noformat}
>    [junit4]   2> 527801 ERROR (qtp1490160324-5239) [n:127.0.0.1:48763_solr c:test_col s:shard1 r:core_node4 x:test_col_shard1_replica2] o.a.s.h.RequestHandlerBase java.lang.RuntimeException: No match, probably bad syntax: TRUE:0:
>    [junit4]   2> 	at org.apache.solr.util.TestInjection.parseValue(TestInjection.java:236)
>    [junit4]   2> 	at org.apache.solr.util.TestInjection.injectFailReplicaRequests(TestInjection.java:159)
>    [junit4]   2> 	at org.apache.solr.update.processor.DistributedUpdateProcessor.setupRequest(DistributedUpdateProcessor.java:356)
> {noformat}
> ...the immediate problem seems to be that TestTestInjection doesn't do anything to cleanup after itself (it never calls {{TestInjection.reset()}}, and doesn't subclass SolrTestCaseJ4) but i'm surprised this hasn't caused a lot more weird failures since this test was added back in december -- i wonder if this this "bad syntax" RuntimeException, when injected into the distributed updates, isn't causing a problem in most cases because of leader initiated recovery, but maybe something specific about the codepaths used in TestCloudDeleteByQuery (which is only a few weeks old) don't work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org