[GitHub] [hbase] Reidddddd commented on a change in pull request #1319: HBASE-24032 [RSGroup] Assign created tables to respective rsgroup aut…

[GitBox <gi...@apache.org>]

Reidddddd commented on a change in pull request #1319: HBASE-24032 [RSGroup] Assign created tables to respective rsgroup aut…
URL: https://github.com/apache/hbase/pull/1319#discussion_r396186194
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
 ##########
 @@ -1181,4 +1224,9 @@ public void moveServers(Set<Address> servers, String targetGroupName) throws IOE
     }
   }
 
+  @Override
+  public String determineRSGroupInfoForTable(TableName tableName) {
+    return script.getRSGroup(tableName.getNamespaceAsString(), tableName.getQualifierAsString());
 
 Review comment:
   > What about store the group info as a TableDescriptor attribute?
   
   Master branch have already done so.
   
   This feature is mainly about when client specified TableDescriptor doesn't have rsgroup configured, and admin want to intercept it before table assignments. It's from server side perspective.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services