Re: Apache 2.0 bug

["William A. Rowe, Jr." <wr...@rowe-clan.net>]

John Sterling noted this as well, and has submitted a patch to correct it.
Expect some action early this week.

If you are right, it would be interesting to discover 'what changed' in
light of the fact that it worked so recently.  No doubt another optmization
or bug fix clobbered this previously correct behavior.

Bill

p.s. good to know some folks are keeping an eye on us :-)  Thanks.

----- Original Message ----- 
From: "Jerry Baker" <jb...@yahoo.com>
Newsgroups: comp.infosystems.www.servers.ms-windows
Sent: Monday, May 28, 2001 11:35 AM
Subject: Apache 2.0 bug


> I downloaded the source via CVS early this morning and noticed that
> server generated pages are sent without any headers at all (redirects,
> etc.). Not sure when it happened, but my source from 5-20 does not have
> this problem.
> 
> -- 
> Jerry Baker
> 
> "If snakes could talk they probably wouldn't waste their time trying to
> get you to eat apples." - Unknown
> 
> PGP Key:
> http://pgpkeys.mit.edu:11371/pks/lookup?op=get&search=0xD4B2493F
> LAME Binaries: http://jerbaker.dhs.org/lame
> 

Re: Apache 2.0 bug

[Graham Leggett <mi...@sharp.fm>]

"William A. Rowe, Jr." wrote:

> John Sterling noted this as well, and has submitted a patch to correct it.
> Expect some action early this week.
> 
> If you are right, it would be interesting to discover 'what changed' in
> light of the fact that it worked so recently.  No doubt another optmization
> or bug fix clobbered this previously correct behavior.

The bug was introduced when the inserting of the HTTP_HEADER filter was
moved to the insert_filter phase. This change made it possible for
AP_FTYPE_HTTP_HEADER filters to run before HTTP_HEADER (and have an
effect), but at the same time left the filter stack empty when errors
occurred before the insert_filter phase.

The patch adds a check to ap_die() to make sure the basic filters are
present, and adds them if they are needed. ap_die() previously assumed
the filter stack would be ok during an error condition, which is not
necessarily the case.

Regards,
Graham
-- 
-----------------------------------------
minfrin@sharp.fm		"There's a moon
					over Bourbon Street
						tonight..."