You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by sh...@apache.org on 2008/08/05 07:44:00 UTC
svn commit: r682587 - in /lucene/solr/trunk: CHANGES.txt
client/java/solrj/src/org/apache/solr/client/solrj/SolrQuery.java
client/java/solrj/test/org/apache/solr/client/solrj/SolrQueryTest.java
Author: shalin
Date: Mon Aug 4 22:43:59 2008
New Revision: 682587
URL: http://svn.apache.org/viewvc?rev=682587&view=rev
Log:
SOLR-591 -- Changed Solrj default value for facet.sort to true
Modified:
lucene/solr/trunk/CHANGES.txt
lucene/solr/trunk/client/java/solrj/src/org/apache/solr/client/solrj/SolrQuery.java
lucene/solr/trunk/client/java/solrj/test/org/apache/solr/client/solrj/SolrQueryTest.java
Modified: lucene/solr/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/CHANGES.txt?rev=682587&r1=682586&r2=682587&view=diff
==============================================================================
--- lucene/solr/trunk/CHANGES.txt (original)
+++ lucene/solr/trunk/CHANGES.txt Mon Aug 4 22:43:59 2008
@@ -568,6 +568,8 @@
Lucene-Java (hossman)
17. SOLR-645: Refactored SimpleFacetsTest (Lars Kotthoff via hossman)
+
+18. SOLR-591: Changed Solrj default value for facet.sort to true (Lars Kotthoff via Shalin)
Build
1. SOLR-411. Changed the names of the Solr JARs to use the defacto standard JAR names based on
Modified: lucene/solr/trunk/client/java/solrj/src/org/apache/solr/client/solrj/SolrQuery.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/client/java/solrj/src/org/apache/solr/client/solrj/SolrQuery.java?rev=682587&r1=682586&r2=682587&view=diff
==============================================================================
--- lucene/solr/trunk/client/java/solrj/src/org/apache/solr/client/solrj/SolrQuery.java (original)
+++ lucene/solr/trunk/client/java/solrj/src/org/apache/solr/client/solrj/SolrQuery.java Mon Aug 4 22:43:59 2008
@@ -194,7 +194,7 @@
* @return facet sort or default of true
*/
public boolean getFacetSort() {
- return this.getBool(FacetParams.FACET_SORT, false);
+ return this.getBool(FacetParams.FACET_SORT, true);
}
/** set facet sort
Modified: lucene/solr/trunk/client/java/solrj/test/org/apache/solr/client/solrj/SolrQueryTest.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/client/java/solrj/test/org/apache/solr/client/solrj/SolrQueryTest.java?rev=682587&r1=682586&r2=682587&view=diff
==============================================================================
--- lucene/solr/trunk/client/java/solrj/test/org/apache/solr/client/solrj/SolrQueryTest.java (original)
+++ lucene/solr/trunk/client/java/solrj/test/org/apache/solr/client/solrj/SolrQueryTest.java Mon Aug 4 22:43:59 2008
@@ -89,4 +89,11 @@
System.out.println(q);
}
+
+ public void testFacetSort() {
+ SolrQuery q = new SolrQuery("dog");
+ assertTrue("expected default value to be true", q.getFacetSort());
+ q.setFacetSort(false);
+ assertFalse("expected set value to be false", q.getFacetSort());
+ }
}