Re: [PR] KAFKA-19571: Race condition between log segment flush and file deletion causing log dir to go offline [kafka]

["mimaison (via GitHub)" <gi...@apache.org>]

mimaison commented on code in PR #20289:
URL: https://github.com/apache/kafka/pull/20289#discussion_r2676403780


##########
core/src/main/scala/kafka/log/LogManager.scala:
##########
@@ -1249,7 +1247,6 @@ class LogManager(logDirs: Seq[File],
         srcLog.renameDir(UnifiedLog.logDeleteDirName(topicPartition), true)
         // Now that replica in source log directory has been successfully renamed for deletion.

Review Comment:
   If we decide to not close the log here, can we update the comment too? including explaining why



##########
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##########
@@ -43,7 +43,7 @@ import java.util.{Collections, Optional, OptionalLong, Properties}
 import org.apache.kafka.server.metrics.KafkaYammerMetrics
 import org.apache.kafka.server.storage.log.FetchIsolation
 import org.apache.kafka.server.util.{FileLock, KafkaScheduler, MockTime, Scheduler}
-import org.apache.kafka.storage.internals.log.{CleanerConfig, FetchDataInfo, LogConfig, LogDirFailureChannel, LogMetricNames, LogManager => JLogManager, LogOffsetsListener, LogStartOffsetIncrementReason, ProducerStateManagerConfig, RemoteIndexCache, UnifiedLog}
+import org.apache.kafka.storage.internals.log.{CleanerConfig, FetchDataInfo, LogConfig, LogDirFailureChannel, LogFileUtils, LogMetricNames, LogOffsetsListener, LogStartOffsetIncrementReason, ProducerStateManagerConfig, RemoteIndexCache, UnifiedLog, LogManager => JLogManager}

Review Comment:
   Can we undo the reordering?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org