You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Joey Echeverria (JIRA)" <ji...@apache.org> on 2011/06/20 18:10:47 UTC
[jira] [Commented] (HBASE-3571) Why do we have a lock in
CompactSplitThread when only ever one instance of this thread?
[ https://issues.apache.org/jira/browse/HBASE-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052031#comment-13052031 ]
Joey Echeverria commented on HBASE-3571:
----------------------------------------
I looked at the code, and it looks like this was fixed in HBASE-3797/HBASE-1476.
> Why do we have a lock in CompactSplitThread when only ever one instance of this thread?
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-3571
> URL: https://issues.apache.org/jira/browse/HBASE-3571
> Project: HBase
> Issue Type: Task
> Components: regionserver
> Reporter: stack
>
> This lock in CompactSplitThread doesn't do anything best as I can tell:
> {code}
> private final ReentrantLock lock = new ReentrantLock();
> {code}
> If two instances of CompactSplitThread, it would not prevent the two threads contending since its local to the instance.
> Remove it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira