You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "Adam Hunyadi (Jira)" <ji...@apache.org> on 2021/02/17 15:22:00 UTC

[jira] [Created] (MINIFICPP-1502) Update processors that take their name/id constructor arguments as values

Adam Hunyadi created MINIFICPP-1502:
---------------------------------------

             Summary: Update processors that take their name/id constructor arguments as values
                 Key: MINIFICPP-1502
                 URL: https://issues.apache.org/jira/browse/MINIFICPP-1502
             Project: Apache NiFi MiNiFi C++
          Issue Type: Task
    Affects Versions: 0.7.0
            Reporter: Adam Hunyadi
             Fix For: 1.0.0


*Background:*

Currently, probably due to copy-pasting, many of the processors take their name and id arguments as values as opposed to const references.

{code:bash|title:Signature grep}
➜  git --no-pager grep '(std::string name, utils::Identifier uuid = utils::Identifier())' | wc -l
46
{code}

*Proposal:*

It should be a trivial change to update these signatures. One should search and replace the mentioned signature and check if changing it has no impact (eg. values are not moved from).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)