You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/24 09:36:16 UTC
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2499: [WIP] Fixes for Coverity issues
apache-mynewt-bot commented on pull request #2499:
URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-784943122
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/drivers/sensors/bma253/src/bma253.c
<details>
```diff
@@ -4561,54 +4551,54 @@
sdsi.user_arg = read_arg;
#if MYNEWT_VAL(BMA253_INT_ENABLE)
- wait_interrupt(&bma253->intr, pdd->int_num);
- BMA253_UNUSED_VAR(cfg);
+ wait_interrupt(&bma253->intr, pdd->int_num);
+ BMA253_UNUSED_VAR(cfg);
#else
- switch (cfg->filter_bandwidth) {
- case BMA253_FILTER_BANDWIDTH_7_81_HZ:
- delay_msec(128);
- break;
- case BMA253_FILTER_BANDWIDTH_15_63_HZ:
- delay_msec(64);
- break;
- case BMA253_FILTER_BANDWIDTH_31_25_HZ:
- delay_msec(32);
- break;
- case BMA253_FILTER_BANDWIDTH_62_5_HZ:
- delay_msec(16);
- break;
- case BMA253_FILTER_BANDWIDTH_125_HZ:
- delay_msec(8);
- break;
- case BMA253_FILTER_BANDWIDTH_250_HZ:
- delay_msec(4);
- break;
- case BMA253_FILTER_BANDWIDTH_500_HZ:
- delay_msec(2);
- break;
- case BMA253_FILTER_BANDWIDTH_1000_HZ:
- delay_msec(1);
- break;
- default:
- delay_msec(1000);
- break;
- }
+ switch (cfg->filter_bandwidth) {
+ case BMA253_FILTER_BANDWIDTH_7_81_HZ:
+ delay_msec(128);
+ break;
+ case BMA253_FILTER_BANDWIDTH_15_63_HZ:
+ delay_msec(64);
+ break;
+ case BMA253_FILTER_BANDWIDTH_31_25_HZ:
+ delay_msec(32);
+ break;
+ case BMA253_FILTER_BANDWIDTH_62_5_HZ:
+ delay_msec(16);
+ break;
+ case BMA253_FILTER_BANDWIDTH_125_HZ:
+ delay_msec(8);
+ break;
+ case BMA253_FILTER_BANDWIDTH_250_HZ:
+ delay_msec(4);
+ break;
+ case BMA253_FILTER_BANDWIDTH_500_HZ:
+ delay_msec(2);
+ break;
+ case BMA253_FILTER_BANDWIDTH_1000_HZ:
+ delay_msec(1);
+ break;
+ default:
+ delay_msec(1000);
+ break;
+ }
#endif
- rc = bma253_read_and_handle_fifo_data(bma253,
+ rc = bma253_read_and_handle_fifo_data(bma253,
FIFO_DATA_X_AND_Y_AND_Z,
&sdsi, stop_ticks, time_ms);
- if (rc != 0) {
- goto done;
- }
-
- if (bma253->hw_cfg_pending) {
- rc = bma253_exec_pending_hw_cfg(bma253);
- BMA253_LOG_ERROR("error bma253_exec_pending_hw_cfg: %d\n", rc);
- }
-
- if (bma253->ev_enabled) {
- sensor_driver_handle_interrupt(&bma253->sensor);
- }
+ if (rc != 0) {
+ goto done;
+ }
+
+ if (bma253->hw_cfg_pending) {
+ rc = bma253_exec_pending_hw_cfg(bma253);
+ BMA253_LOG_ERROR("error bma253_exec_pending_hw_cfg: %d\n", rc);
+ }
+
+ if (bma253->ev_enabled) {
+ sensor_driver_handle_interrupt(&bma253->sensor);
+ }
rc = bma253_set_int_enable(bma253, &int_enable_org);
@@ -5013,8 +5003,8 @@
goto done;
}
- int_enable.s_tap_int_enable = tap_type == BMA253_TAP_TYPE_SINGLE;
- int_enable.d_tap_int_enable = tap_type == BMA253_TAP_TYPE_DOUBLE;
+ int_enable.s_tap_int_enable = tap_type == BMA253_TAP_TYPE_SINGLE;
+ int_enable.d_tap_int_enable = tap_type == BMA253_TAP_TYPE_DOUBLE;
rc = bma253_set_int_enable(bma253, &int_enable);
if (rc != 0) {
```
</details>
#### hw/drivers/sensors/bme680/src/bme680.c
<details>
```diff
@@ -1685,7 +1687,7 @@
hal_gpio_write(interface->si_cs_pin, 0);
(void)hal_spi_tx_val(interface->si_num, reg_addr | 0x80);
/* Use reg_data for the txbuf as well.
- The contents don't matter since we're reading */
+ The contents don't matter since we're reading */
hal_spi_txrx(interface->si_num, reg_data, reg_data, len);
hal_gpio_write(interface->si_cs_pin, 1);
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org