You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/01 12:25:37 UTC

[GitHub] [incubator-nuttx] fjpanag opened a new pull request #4023: lpc17_40_progmem: fixed compilation issues.

fjpanag opened a new pull request #4023:
URL: https://github.com/apache/incubator-nuttx/pull/4023


   ## Summary
   Fixes a couple of issues with the PROGMEM driver of the LPC17xx and LPC40xx MCUs.
   
   1. The file `lpc17_40_progmem.c` was incorrectly build only when `CONFIG_MTD_PROGMEM` was set. In fact there is a specific option for this, `CONFIG_LPC17_40_PROGMEM`, which was not used.
   
   2. Also a fix in a cast that, at least for me, caused a compiler error.
   
   ## Impact
   1. PROGMEM can be used without MTD.
   2. Code builds.
   
   ## Testing
   Build test only.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] fjpanag commented on pull request #4023: lpc17_40_progmem: fixed compilation issues.

Posted by GitBox <gi...@apache.org>.
fjpanag commented on pull request #4023:
URL: https://github.com/apache/incubator-nuttx/pull/4023#issuecomment-872211627


   Regarding the style issue, I don't think that it can be fixed.  
   I think the cast confuses the tool?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4023: lpc17_40_progmem: fixed compilation issues.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4023:
URL: https://github.com/apache/incubator-nuttx/pull/4023


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org