You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/02/01 15:26:07 UTC

[GitHub] [parquet-mr] wangyum opened a new pull request #860: PARQUET-1969: Test by GithubAction

wangyum opened a new pull request #860:
URL: https://github.com/apache/parquet-mr/pull/860


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] wangyum commented on pull request #860: PARQUET-1969: Test by GithubAction

Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #860:
URL: https://github.com/apache/parquet-mr/pull/860#issuecomment-771644735


   > Would it automatically exchange the automatic Travis jobs in the PR?
   
   Yes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] wangyum commented on pull request #860: PARQUET-1969: Test by GithubAction

Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #860:
URL: https://github.com/apache/parquet-mr/pull/860#issuecomment-771332722






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] gszadovszky commented on pull request #860: PARQUET-1969: Test by GithubAction

Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #860:
URL: https://github.com/apache/parquet-mr/pull/860#issuecomment-771713001


   Thanks @wangyum, @dossett. Sounds great. I'll push this change soon.
   
   One last question: shouldn't we remove the `.travis.yml` config to disable Travis builds??


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] gszadovszky commented on pull request #860: PARQUET-1969: Test by GithubAction

Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #860:
URL: https://github.com/apache/parquet-mr/pull/860#issuecomment-771713001


   Thanks @wangyum, @dossett. Sounds great. I'll push this change soon.
   
   One last question: shouldn't we remove the `.travis.yml` config to disable Travis builds??


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] dossett commented on pull request #860: PARQUET-1969: Test by GithubAction

Posted by GitBox <gi...@apache.org>.
dossett commented on pull request #860:
URL: https://github.com/apache/parquet-mr/pull/860#issuecomment-771713863


   Yes, that should be removed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] dossett commented on pull request #860: PARQUET-1969: Test by GithubAction

Posted by GitBox <gi...@apache.org>.
dossett commented on pull request #860:
URL: https://github.com/apache/parquet-mr/pull/860#issuecomment-771647439


   In my (admittedly limited) recent experience, travis support for open source projects is declining and github actions are becoming more popular for tests like these.  I switched one open source project by company manages from Travis to Github Actions and have been extremely pleased with the results.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] dossett commented on pull request #860: PARQUET-1969: Test by GithubAction

Posted by GitBox <gi...@apache.org>.
dossett commented on pull request #860:
URL: https://github.com/apache/parquet-mr/pull/860#issuecomment-771713863


   Yes, that should be removed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] gszadovszky merged pull request #860: PARQUET-1969: Test by GithubAction

Posted by GitBox <gi...@apache.org>.
gszadovszky merged pull request #860:
URL: https://github.com/apache/parquet-mr/pull/860


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] gszadovszky merged pull request #860: PARQUET-1969: Test by GithubAction

Posted by GitBox <gi...@apache.org>.
gszadovszky merged pull request #860:
URL: https://github.com/apache/parquet-mr/pull/860


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] wangyum commented on pull request #860: PARQUET-1969: Test by GithubAction

Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #860:
URL: https://github.com/apache/parquet-mr/pull/860#issuecomment-771332722


   Tested by https://github.com/wangyum/parquet-mr/runs/1811695243?check_suite_focus=true


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org