You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Matt Juntunen <ma...@gmail.com> on 2021/07/06 21:17:43 UTC
[numbers] 1.0 Release
Hello,
Are we ready for a 1.0 release of commons-numbers? Any pending updates or
blockers?
Regards,
Matt J
Re: [numbers] 1.0 Release
Posted by Gilles Sadowski <gi...@gmail.com>.
Le ven. 9 juil. 2021 à 12:55, Matt Juntunen
<ma...@gmail.com> a écrit :
>
> If there aren't any objections, then I could try to get a release ready
> this weekend. I believe we are skipping the commons-numbers-arrays and
> commons-numbers-complex-streams modules for this release, correct?
No, "commons-numbers-arrays" should go in.
Regards,
Gilles
>
> -Matt J
>
> On Tue, Jul 6, 2021 at 5:17 PM Matt Juntunen <ma...@gmail.com>
> wrote:
>
> > Hello,
> >
> > Are we ready for a 1.0 release of commons-numbers? Any pending updates or
> > blockers?
> >
> > Regards,
> > Matt J
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [numbers] 1.0 Release
Posted by Gilles Sadowski <gi...@gmail.com>.
Le sam. 10 juil. 2021 à 19:23, Gary Gregory <ga...@gmail.com> a écrit :
>
> Since tags make sense to see what's been ADDED since 1.0.
Well, of course. IMHO even for the additions, the tags are next to useless in
Commons components.
Gilles
>
> On Sat, Jul 10, 2021, 13:20 Gilles Sadowski <gi...@gmail.com> wrote:
>
> > Le sam. 10 juil. 2021 à 18:30, Matt Juntunen
> > <ma...@gmail.com> a écrit :
> > >
> > > Do we want to add "@since" tags to Javadocs?
> >
> > I don't think that they add much.
> >
> > Gilles
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [numbers] 1.0 Release
Posted by Gary Gregory <ga...@gmail.com>.
Since tags make sense to see what's been ADDED since 1.0.
On Sat, Jul 10, 2021, 13:20 Gilles Sadowski <gi...@gmail.com> wrote:
> Le sam. 10 juil. 2021 à 18:30, Matt Juntunen
> <ma...@gmail.com> a écrit :
> >
> > Do we want to add "@since" tags to Javadocs?
>
> I don't think that they add much.
>
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [numbers] 1.0 Release
Posted by Gilles Sadowski <gi...@gmail.com>.
Le sam. 10 juil. 2021 à 18:30, Matt Juntunen
<ma...@gmail.com> a écrit :
>
> Do we want to add "@since" tags to Javadocs?
I don't think that they add much.
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [numbers] 1.0 Release
Posted by Matt Juntunen <ma...@gmail.com>.
Do we want to add "@since" tags to Javadocs?
-Matt J
On Sat, Jul 10, 2021 at 9:36 AM Alex Herbert <al...@gmail.com>
wrote:
> On Sat, 10 Jul 2021 at 13:12, Matt Juntunen <ma...@gmail.com>
> wrote:
>
> > I've removed the BiConsumer interface in NUMBERS-166. I also renamed the
> > "accept" method to "apply" to better indicate its active role in
> modifying
> > the arguments.
> >
> > If there aren't any other changes required, I'll plan on starting the
> > release tonight or tomorrow sometime. To confirm, all modules will be
> > released with the exception of commons-numbers-complex-streams.
> >
> >
> +1
>
Re: [numbers] 1.0 Release
Posted by Alex Herbert <al...@gmail.com>.
On Sat, 10 Jul 2021 at 13:12, Matt Juntunen <ma...@gmail.com>
wrote:
> I've removed the BiConsumer interface in NUMBERS-166. I also renamed the
> "accept" method to "apply" to better indicate its active role in modifying
> the arguments.
>
> If there aren't any other changes required, I'll plan on starting the
> release tonight or tomorrow sometime. To confirm, all modules will be
> released with the exception of commons-numbers-complex-streams.
>
>
+1
Re: [numbers] 1.0 Release
Posted by Matt Juntunen <ma...@gmail.com>.
I've removed the BiConsumer interface in NUMBERS-166. I also renamed the
"accept" method to "apply" to better indicate its active role in modifying
the arguments.
If there aren't any other changes required, I'll plan on starting the
release tonight or tomorrow sometime. To confirm, all modules will be
released with the exception of commons-numbers-complex-streams.
Regards,
Matt J
On Sat, Jul 10, 2021 at 7:17 AM Alex Herbert <al...@gmail.com>
wrote:
> On Sat, 10 Jul 2021 at 09:19, Gilles Sadowski <gi...@gmail.com>
> wrote:
>
> > Le ven. 9 juil. 2021 à 16:21, Alex Herbert <al...@gmail.com> a
> > écrit :
> > >
> > > [...]
> > > SortInPlace
> > >
> > > The latter was recently ported from Commons Math. For that class there
> > is a
> > > warning about using varargs for the signature of BiConsumer<double[],
> > > double[][]>. It is using accept(double[], double[]...). I am not sure
> if
> > > this is a real problem or not. The varargs is not allowed in the
> > BiConsumer
> > > signature. So perhaps it should be removed from the implementation of
> the
> > > method.
> >
> > The varargs API is handy for sorting related arrays without the user
> having
> > to create a temporary array of arrays.
> >
> > I don't also know whether the warning (I didn't notice it) is a problem,
> > but
> > if it is, I'd rather remove the "implements" clause than the method. [I
> > don't
> > have a real-life example for using the interface.]
> >
>
> +1 to removing the interface. The vargargs has more benefit than the
> interface declaration.
>
> Alex
>
Re: [numbers] 1.0 Release
Posted by Alex Herbert <al...@gmail.com>.
On Sat, 10 Jul 2021 at 09:19, Gilles Sadowski <gi...@gmail.com> wrote:
> Le ven. 9 juil. 2021 à 16:21, Alex Herbert <al...@gmail.com> a
> écrit :
> >
> > [...]
> > SortInPlace
> >
> > The latter was recently ported from Commons Math. For that class there
> is a
> > warning about using varargs for the signature of BiConsumer<double[],
> > double[][]>. It is using accept(double[], double[]...). I am not sure if
> > this is a real problem or not. The varargs is not allowed in the
> BiConsumer
> > signature. So perhaps it should be removed from the implementation of the
> > method.
>
> The varargs API is handy for sorting related arrays without the user having
> to create a temporary array of arrays.
>
> I don't also know whether the warning (I didn't notice it) is a problem,
> but
> if it is, I'd rather remove the "implements" clause than the method. [I
> don't
> have a real-life example for using the interface.]
>
+1 to removing the interface. The vargargs has more benefit than the
interface declaration.
Alex
Re: [numbers] 1.0 Release
Posted by Gilles Sadowski <gi...@gmail.com>.
Le ven. 9 juil. 2021 à 16:21, Alex Herbert <al...@gmail.com> a écrit :
>
> [...]
> SortInPlace
>
> The latter was recently ported from Commons Math. For that class there is a
> warning about using varargs for the signature of BiConsumer<double[],
> double[][]>. It is using accept(double[], double[]...). I am not sure if
> this is a real problem or not. The varargs is not allowed in the BiConsumer
> signature. So perhaps it should be removed from the implementation of the
> method.
The varargs API is handy for sorting related arrays without the user having
to create a temporary array of arrays.
I don't also know whether the warning (I didn't notice it) is a problem, but
if it is, I'd rather remove the "implements" clause than the method. [I don't
have a real-life example for using the interface.]
Regards,
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [numbers] 1.0 Release
Posted by Alex Herbert <al...@gmail.com>.
On Fri, 9 Jul 2021 at 11:55, Matt Juntunen <ma...@gmail.com>
wrote:
> If there aren't any objections, then I could try to get a release ready
> this weekend. I believe we are skipping the commons-numbers-arrays and
> commons-numbers-complex-streams modules for this release, correct?
>
>
Thanks.
Definitely omit commons-numbers-complex-streams. There was a discussion a
while back about an alternative to this module that would represent arrays
of complex numbers using just arrays of primitives for the real and
imaginary parts.
Looking at commons-numbers-arrays it only has two classes:
MultidimensionalCounter
SortInPlace
The latter was recently ported from Commons Math. For that class there is a
warning about using varargs for the signature of BiConsumer<double[],
double[][]>. It is using accept(double[], double[]...). I am not sure if
this is a real problem or not. The varargs is not allowed in the BiConsumer
signature. So perhaps it should be removed from the implementation of the
method.
Alex
Re: [numbers] 1.0 Release
Posted by Matt Juntunen <ma...@gmail.com>.
If there aren't any objections, then I could try to get a release ready
this weekend. I believe we are skipping the commons-numbers-arrays and
commons-numbers-complex-streams modules for this release, correct?
-Matt J
On Tue, Jul 6, 2021 at 5:17 PM Matt Juntunen <ma...@gmail.com>
wrote:
> Hello,
>
> Are we ready for a 1.0 release of commons-numbers? Any pending updates or
> blockers?
>
> Regards,
> Matt J
>