[GitHub] [dubbo-go] cvictory opened a new issue #750: [bug] the registry notify empty address, the RegistryDirectory cannot clear the invokers

[GitBox <gi...@apache.org>]

cvictory opened a new issue #750:
URL: https://github.com/apache/dubbo-go/issues/750


   ```
   func (dir *RegistryDirectory) refreshInvokers(events ...*registry.ServiceEvent) {
   	var oldInvokers []protocol.Invoker
   
   	// in batch mode, it is safe to remove since we have the complete list of events.
   	if len(events) > 1 {
   		dir.cacheInvokersMap.Range(func(k, v interface{}) bool {
   			if !dir.eventMatched(k.(string), events) {
   				if invoker := dir.uncacheInvokerWithKey(k.(string)); invoker != nil {
   					oldInvokers = append(oldInvokers, invoker)
   				}
   			}
   			return true
   		})
   	}
   
   	for _, event := range events {
   		logger.Debugf("registry update, result{%s}", event)
   		if oldInvoker, _ := dir.cacheInvokerByEvent(event); oldInvoker != nil {
   			oldInvokers = append(oldInvokers, oldInvoker)
   		}
   	}
   
   	if len(events) > 0 {
   		dir.setNewInvokers()
   	}
   
   	// After dir.cacheInvokers is updated,destroy the oldInvoker
   	// Ensure that no request will enter the oldInvoker
   	for _, invoker := range oldInvokers {
   		invoker.Destroy()
   	}
   }
   ```
   
   when the argument `events` is empty, we should delete all the invokers, but now it don't do anything.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks closed issue #750: [bug] the registry notify empty address, the RegistryDirectory cannot clear the invokers

[GitBox <gi...@apache.org>]

AlexStocks closed issue #750:
URL: https://github.com/apache/dubbo-go/issues/750


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org