You are viewing a plain text version of this content. The canonical link for it is here.

Posted to yarn-issues@hadoop.apache.org by "Junping Du (JIRA)" <ji...@apache.org> on 2014/01/08 04:37:03 UTC

[jira] [Updated] (YARN-1569) For handle(SchedulerEvent) in FifoScheduler and CapacityScheduler, SchedulerEvent should get checked (instanceof) for appropriate type before casting

     [ https://issues.apache.org/jira/browse/YARN-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Junping Du updated YARN-1569:
-----------------------------

    Summary: For handle(SchedulerEvent) in FifoScheduler and CapacityScheduler, SchedulerEvent should get checked (instanceof) for appropriate type before casting  (was: For handl(SchedulerEvent) in FifoScheduler and CapacityScheduler, SchedulerEvent should get checked (instanceof) for appropriate type before casting)

> For handle(SchedulerEvent) in FifoScheduler and CapacityScheduler, SchedulerEvent should get checked (instanceof) for appropriate type before casting
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1569
>                 URL: https://issues.apache.org/jira/browse/YARN-1569
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>            Reporter: Junping Du
>            Priority: Minor
>              Labels: newbie
>
> As following: http://wiki.apache.org/hadoop/CodeReviewChecklist, we should always check appropriate type before casting. handle(SchedulerEvent) in FifoScheduler and CapacityScheduler didn't check so far (no bug there now) but should be improved as FairScheduler.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)