You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2023/01/05 22:01:50 UTC
[GitHub] [streampipes] flomickl opened a new pull request, #1044: Sp 584
flomickl opened a new pull request, #1044:
URL: https://github.com/apache/streampipes/pull/1044
<!--
~ Licensed to the Apache Software Foundation (ASF) under one or more
~ contributor license agreements. See the NOTICE file distributed with
~ this work for additional information regarding copyright ownership.
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
~
-->
<!--
Thanks for contributing! Here are some tips you can follow to help us incorporate your contribution quickly and easily:
1. If this is your first time, please read our contributor guidelines:
- https://streampipes.apache.org/getinvolved.html
- https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
2. Make sure the PR title is formatted like: `[#<GitHub issue id>] PR title ...`
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., `[WIP][#<GitHub issue id>] PR title ...`.
4. Please write your PR title to summarize what this PR proposes/fixes.
5. Link the PR to the corresponding GitHub issue (if present) in the `Development` section in the right menu bar.
6. Be sure to keep the PR description updated to reflect all changes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
8. Make sure tests pass via `mvn clean install`.
9. (Optional) If the contribution is large, please file an Apache ICLA
- http://apache.org/licenses/icla.pdf
-->
### Purpose
Implement #777
### Remarks
I created some follow-up tickets like #1041 #1042 and #1043 to split this big change into separate tasks.
Last time it took so long that the issue was too old to be merged.
PR introduces (a) deprecation(s): yes
Implemented the Apache SIS maven package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on pull request #1044: Implementing possibility for reprojection Coordinates
Posted by GitBox <gi...@apache.org>.
bossenti commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1374149277
@flomickl thanks a lot for your explanation 🙏🏼
With respect to the failing build: Maven complains here that it found four files without an Apache header.
You can find an overview here:
https://github.com/apache/streampipes/actions/runs/3850696943/jobs/6561136292#step:4:14597
tldr; these are the four SQL files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] flomickl commented on pull request #1044: Sp 584
Posted by GitBox <gi...@apache.org>.
flomickl commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1374071219
@bossenti
Hi, sorry I added the wrong ticket yesterday evening. I updated it now. It is the coordinate reprojection processor. A while ago, I created already a PR but because of the many pushes in the dev branch, it was too complicated to merge.
So I created a new, clean version.
The empty SQL Scripts are correct. This is for a clean startup in the corresponding docker-compose file.
So it is guaranteed that the container is built, even without the input data.
This way the processor does not run in any time out, which takes longer anyway from the user perspective. Instead, there is a check in the onInvocation method if the database is set up with data. If not, an SpRuntime Exception is thrown.
How to add the data is written in the README.
There are some follow-up tickets related to this issue:
#1041 #1042 #1043
Mainly the processor does some coordinate reprojection so transform some WGS84 coordinates (lat long) to an UTM projection.
Hope this makes is clearer now. I will add some longer descriptions in the wiki, to prepare the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on pull request #1044: Implementing possibility for reprojection Coordinates
Posted by GitBox <gi...@apache.org>.
bossenti commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1380822490
@flomickl that's great
It would be great if you could rebase your branch once but then I think you are ready to go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implementing possibility for reprojection Coordinates (streampipes)
Posted by "flomickl (via GitHub)" <gi...@apache.org>.
flomickl commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1416032823
@bossenti there was a conflict in the pom file, so I fixed it here on the web IDE. Is it correct that the dev branch should be merged here? Is this a default behavior of GitHub and the web IDE or should it be a rebased? I didn't want to make it as complicated as last time....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implementing possibility for reprojection Coordinates (streampipes)
Posted by "flomickl (via GitHub)" <gi...@apache.org>.
flomickl commented on code in PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#discussion_r1095197663
##########
streampipes-extensions/streampipes-processors-geo-jvm/pom.xml:
##########
@@ -63,7 +63,17 @@
<dependency>
<groupId>org.locationtech.jts</groupId>
<artifactId>jts-core</artifactId>
- <version>1.16.1</version>
+ <version>1.19.0</version>
Review Comment:
The parent pom would also need new code format process in an extra commit!
Did not want to add this here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] flomickl commented on pull request #1044: Implementing possibility for reprojection Coordinates
Posted by GitBox <gi...@apache.org>.
flomickl commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1382337179
oh man, why?
I just did a simple rebase and this was the result
what to do now? @bossenti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on pull request #1044: Implementing possibility for reprojection Coordinates
Posted by GitBox <gi...@apache.org>.
bossenti commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1382680227
@flomickl it's hard to tell from the sidelines, so I took a quick look locally
I suspect you rebased the branch with an outdated version of `dev`, so I just did another rebase with the current version of `dev`
As far as I can see the diff now looks as expected, can you please check this briefly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] flomickl commented on pull request #1044: Implementing possibility for reprojection Coordinates
Posted by GitBox <gi...@apache.org>.
flomickl commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1379897361
@bossenti Hm if you mention it. Nothing prevent it to include the license text to an empty script that reference to another file.
I will add them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] flomickl commented on pull request #1044: Implementing possibility for reprojection Coordinates
Posted by GitBox <gi...@apache.org>.
flomickl commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1381360499
rebase done :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implementing possibility for reprojection Coordinates (streampipes)
Posted by "flomickl (via GitHub)" <gi...@apache.org>.
flomickl commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1412913728
@dominikriemer can you check the code as well please? O:-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implementing possibility for reprojection Coordinates (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1419620690
@flomickl I don't think we have a preference for rebasing or merge commits in this project
So creating a merge commit is just fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implementing possibility for reprojection Coordinates (streampipes)
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe merged PR #1044:
URL: https://github.com/apache/streampipes/pull/1044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implementing possibility for reprojection Coordinates (streampipes)
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on code in PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#discussion_r1094331788
##########
streampipes-extensions/streampipes-processors-geo-jvm/pom.xml:
##########
@@ -63,7 +63,17 @@
<dependency>
<groupId>org.locationtech.jts</groupId>
<artifactId>jts-core</artifactId>
- <version>1.16.1</version>
+ <version>1.19.0</version>
Review Comment:
Hey @flomickl,
the parent pom ensures that we use the same version of a dependency within the whole project.
Therefore, the dependency must be added to the `<dependencyManagement>` tag with the version in the parent pom.xml.
To use this dependency you can add it the to the pom.xml in the module that requires the dependency to the `<dependencies>` tag. The version should only be defined in the parent pom.xml and not in the module pom.xml.
The only exception are the StreamPipes dependencies.
Does this help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] flomickl commented on pull request #1044: Implementing possibility for reprojection Coordinates
Posted by GitBox <gi...@apache.org>.
flomickl commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1374402970
@bossenti
Ah ok.
What to do with this kind of files?
Exclude them? They have anyway another header format due commend syntax `--`.
So like markdown or java, there is a third option now.
In
PostgreSQL_Data_Script.sql
PostgreSQL_FKey_Script.sql
PostgreSQL_Table_Script.sql
following information could be placed:
-- Usage the data is in accordance to your user profile terms of use. The
-- terms of use can be found here: http://www.epsg-registry.org/help/xml/Terms_Of_Use.html
EPSG_FINISH.sql is Apache conform and therefore the following could be added:
```
--
-- Licensed to the Apache Software Foundation (ASF) under one or more
-- contributor license agreements. See the NOTICE file distributed with
-- this work for additional information regarding copyright ownership.
-- The ASF licenses this file to You under the Apache License, Version 2.0
-- (the "License"); you may not use this file except in compliance with
-- the License. You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing, software
-- distributed under the License is distributed on an "AS IS" BASIS,
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-- See the License for the specific language governing permissions and
-- limitations under the License.
--
--
```
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on pull request #1044: Implementing possibility for reprojection Coordinates
Posted by GitBox <gi...@apache.org>.
bossenti commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1381398126
@flomickl there seems to be something wrong...
Your diff is huge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implementing possibility for reprojection Coordinates (streampipes)
Posted by "flomickl (via GitHub)" <gi...@apache.org>.
flomickl commented on code in PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#discussion_r1093476679
##########
streampipes-extensions/streampipes-processors-geo-jvm/pom.xml:
##########
@@ -63,7 +63,17 @@
<dependency>
<groupId>org.locationtech.jts</groupId>
<artifactId>jts-core</artifactId>
- <version>1.16.1</version>
+ <version>1.19.0</version>
Review Comment:
@tenthe You mean here?
https://github.com/apache/streampipes/blob/dev/pom.xml ?
and something like
```
...
<jts.version>1.19.0</jts.version>
...
<dependency>
<groupId>org.locationtech.jts<</groupId>
<artifactId>jts-core</artifactId>
<version>${jts.version}</version>
</dependency>
```
Should I do it for
- jts
- postgresql
- sis
- com.squareup.okhttp
I did not add
```
<dependency>
<groupId>com.squareup.okhttp3</groupId>
<artifactId>okhttp</artifactId>
<version>3.13.1</version>
</dependency>
```
The result in the geo.jvm pom should also be changed to
```
<dependency>
<groupId>org.locationtech.jts<</groupId>
<artifactId>jts-core</artifactId>
<version>${jts.version}</version>
</dependency>
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implementing possibility for reprojection Coordinates (streampipes)
Posted by "flomickl (via GitHub)" <gi...@apache.org>.
flomickl commented on code in PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#discussion_r1093476679
##########
streampipes-extensions/streampipes-processors-geo-jvm/pom.xml:
##########
@@ -63,7 +63,17 @@
<dependency>
<groupId>org.locationtech.jts</groupId>
<artifactId>jts-core</artifactId>
- <version>1.16.1</version>
+ <version>1.19.0</version>
Review Comment:
@tenthe You mean here?
https://github.com/apache/streampipes/blob/dev/pom.xml ?
and something like
```
...
<jts.version>1.19.0</jts.version>
...
<dependency>
<groupId>org.locationtech.jts<</groupId>
<artifactId>jts-core</artifactId>
<version>${jts.version}</version>
</dependency>
```
Should I do it for
- jts
- postgresql
- sis
- com.squareup.okhttp
I did not add
```
<dependency>
<groupId>com.squareup.okhttp3</groupId>
<artifactId>okhttp</artifactId>
<version>3.13.1</version>
</dependency>
```
The result in the geo.jvm pom should also be changed to
```
<dependency>
<groupId>org.locationtech.jts<</groupId>
<artifactId>jts-core</artifactId>
<version>${jts.version}</version>
</dependency>
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implementing possibility for reprojection Coordinates (streampipes)
Posted by "flomickl (via GitHub)" <gi...@apache.org>.
flomickl commented on code in PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#discussion_r1093854742
##########
streampipes-extensions/streampipes-processors-geo-jvm/pom.xml:
##########
@@ -63,7 +63,17 @@
<dependency>
<groupId>org.locationtech.jts</groupId>
<artifactId>jts-core</artifactId>
- <version>1.16.1</version>
+ <version>1.19.0</version>
Review Comment:
@tenthe You mean here?
https://github.com/apache/streampipes/blob/dev/pom.xml ?
What is the difference between these two pom files?
The change should look something like:
```
...
<jts.version>1.19.0</jts.version>
...
<dependency>
<groupId>org.locationtech.jts<</groupId>
<artifactId>jts-core</artifactId>
<version>${jts.version}</version>
</dependency>
```
Should I do it for these entries?
- jts
- postgresql -> pretty sure that this entry already exist sin the parent pom
- sis
- com.squareup.okhttp
I did not add
```
<dependency>
<groupId>com.squareup.okhttp3</groupId>
<artifactId>okhttp</artifactId>
<version>3.13.1</version>
</dependency>
```
The entry in the geo.jvm pom should also be changed to following entry?
```
<dependency>
<groupId>org.locationtech.jts<</groupId>
<artifactId>jts-core</artifactId>
<version>${jts.version}</version>
</dependency>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implementing possibility for reprojection Coordinates (streampipes)
Posted by "flomickl (via GitHub)" <gi...@apache.org>.
flomickl commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1412338134
btw I found out what happened. Somehow, the rebase command was setup with the --onto flag in my git configs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implementing possibility for reprojection Coordinates (streampipes)
Posted by "flomickl (via GitHub)" <gi...@apache.org>.
flomickl commented on code in PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#discussion_r1095187476
##########
streampipes-extensions/streampipes-processors-geo-jvm/pom.xml:
##########
@@ -63,7 +63,17 @@
<dependency>
<groupId>org.locationtech.jts</groupId>
<artifactId>jts-core</artifactId>
- <version>1.16.1</version>
+ <version>1.19.0</version>
Review Comment:
@tenthe I updated the pom files.
I also run manual tests again. Everything as expected.
I left this inside, but sure that this could be removed in another ticket. The version is also outdated in both pom files.
```
<dependency>
<groupId>com.squareup.okhttp3</groupId>
<artifactId>okhttp</artifactId>
<version>3.13.1</version>
</dependency>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] flomickl commented on pull request #1044: Implementing possibility for reprojection Coordinates
Posted by GitBox <gi...@apache.org>.
flomickl commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1380694519
@bossenti added and style check complete. Anything else to do before merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] flomickl commented on pull request #1044: Sp 584
Posted by GitBox <gi...@apache.org>.
flomickl commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1374073234
i don't understand the validate-pr / run-rat-plugin check and why it failed?
What does this mean?
```
Error: Failed to execute goal org.apache.rat:apache-rat-plugin:0.13:check (license-check) on project streampipes-parent: Too many files with unapproved license: 4 See RAT report in: /home/runner/work/streampipes/streampipes/target/rat.txt -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Error: Process completed with exit code 1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on pull request #1044: Implementing possibility for reprojection Coordinates
Posted by GitBox <gi...@apache.org>.
bossenti commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1374404361
The suggested header looks fine to me
@tenthe do we need to add the new header type somewhere in Maven?
> In
PostgreSQL_Data_Script.sql
PostgreSQL_FKey_Script.sql
PostgreSQL_Table_Script.sql
following information could be placed:
-- Usage the data is in accordance to your user profile terms of use. The
-- terms of use can be found here: http://www.epsg-registry.org/help/xml/Terms_Of_Use.html
@flomickl I don't really get why we cannot add our header here? These are just empty files, right?
But if anything prevents us here from adding an Apache header, I would exclude them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] tenthe commented on a diff in pull request #1044: Implementing possibility for reprojection Coordinates
Posted by GitBox <gi...@apache.org>.
tenthe commented on code in PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#discussion_r1070231080
##########
streampipes-extensions/streampipes-processors-geo-jvm/pom.xml:
##########
@@ -63,7 +63,17 @@
<dependency>
<groupId>org.locationtech.jts</groupId>
<artifactId>jts-core</artifactId>
- <version>1.16.1</version>
+ <version>1.19.0</version>
Review Comment:
Hi @flomickl can you please add the dependencies to the <dependencyManagement> tag in the parent pom.
Then you don't need the version number in this pom.
In the parent pom you can also create a variable like it is done for other dependencies.
If you have any questions, just let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on pull request #1044: Implementing possibility for reprojection Coordinates
Posted by GitBox <gi...@apache.org>.
bossenti commented on PR #1044:
URL: https://github.com/apache/streampipes/pull/1044#issuecomment-1385669726
@flomickl I just gave it another rebase to keep up with recent changes 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org