You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/05/05 04:23:06 UTC

[GitHub] [echarts] pissang opened a new pull request #14862: Enhance visual regression test

pissang opened a new pull request #14862:
URL: https://github.com/apache/echarts/pull/14862


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [x] others
   
   
   
   ## What does this PR do?
   
   This PR enhances visual regression test.
   
   ### Details
   
   Major changes:
   
   #### 1. Brand new UI
   
   ![image](https://user-images.githubusercontent.com/841551/117091669-a0d1d700-ad8e-11eb-9274-1f618cb0cbb5.png)
   
   #### 2. Management of multiple versions of run
   
   Because we reduced the size of screenshot storage significantly in https://github.com/apache/echarts/pull/14745 . We can now save multiple versions of test run on our disk now. 
   
   ![image](https://user-images.githubusercontent.com/841551/117096122-b816c180-ad9a-11eb-9921-7b903d15f68c.png)
   
   We can manage all test runs in the `ALL RUNS` dialog. 
   
   #### 3. Targeting nightly build
   
   In https://github.com/apache/echarts/pull/14754 we add nightly build for echarts. It publishes the master branch every day.
   So we can now choose to compare to the nightly build. Which can minimize the difference between the dev branch and the master branch if we wan't test if the dev branch breaks something.
   
   ![image](https://user-images.githubusercontent.com/841551/117096373-6cb0e300-ad9b-11eb-8ef5-5eb688e28ed1.png)
   
   Just check the nightly build checkbox and choose nightly versions.
   
   #### 4. Report generation
   
   If we wan't to share our test result with others. We can generate the report by simply clicking the `Report`link.
   
   ![image](https://user-images.githubusercontent.com/841551/117096641-50617600-ad9c-11eb-91af-880cfb9e0d03.png)
   
   Generated report HTML can be saved to local and sent to others. All images are embeded
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14862: Enhance visual regression test

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14862:
URL: https://github.com/apache/echarts/pull/14862#issuecomment-832402820


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14862: Enhance visual regression test

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14862:
URL: https://github.com/apache/echarts/pull/14862#issuecomment-832402104


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #14862: Enhance visual regression test

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #14862:
URL: https://github.com/apache/echarts/pull/14862


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org