[jira] [Commented] (CB-7494) cordova-windows fails to build app with unicode name using cordova/build.bat script

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125634#comment-14125634 ] 

ASF GitHub Bot commented on CB-7494:
------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-windows/pull/44

    CB-7494 Fixes wrong replacements in *.appxmanifest files

    Fix for https://issues.apache.org/jira/browse/CB-7494
    
    Fixes cordova/build script failure when project's name contain unicode and config.xml is empty (e.g. when project created using bin/create script)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-windows CB-7494

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/44.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #44
    
----
commit fdce7411529e3630f6b7c17f9942a3113ba67c6e
Author: Vladimir Kotikov <v-...@microsoft.com>
Date:   2014-09-08T14:36:40Z

    CB-7494 Fixes wrong replacements in *.appxmanifest files

----


> cordova-windows fails to build app with unicode name using cordova/build.bat script
> -----------------------------------------------------------------------------------
>
>                 Key: CB-7494
>                 URL: https://issues.apache.org/jira/browse/CB-7494
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>            Reporter: Vladimir Kotikov
>
> Repro steps (in cordova-windows repo):
> {{windows\bin\create "testcreate 応用" com.test.app 応用}}
> {{".windows\testcreate 応用\cordova\build"}}
> Expected:
> App builds successfully.
> Actual:
> {noformat}
> package.windows80.appxmanifest(35,22): error APPX3032: App manifest validation failed.
> Value '応用' of attribute '/Package/Applications/Application/@Id' is n ot a valid ASCII Windows ID.
> It must contain one or more parts, separated with periods, where each part contains only characters a-z, A-Z, 0-9, and does no t start with a digit.
> [d:\cordova\cordova-windows\windows\testcreate 応用\CordovaApp.Windows80.jsproj]
> {noformat}
> This doesn't affects CLI
> The reason is that bin/create script write app name and app id in wrong places at *.manifest files



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)