You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/20 10:58:57 UTC
[GitHub] [airflow] TobKed opened a new pull request #13193: Add Prerequisites that new provider package should fulfils
TobKed opened a new pull request #13193:
URL: https://github.com/apache/airflow/pull/13193
Related to: [Add list of prerequisites that new provider package should fulfill](https://github.com/apache/airflow/issues/10386)
- [x] directory structure (possibly automated templates or script to create them)
- [ ] usage scenarios for connections in hooks (see discussion in #12128)
- [ ] Information about what is required:
- [ ] hooks
- [ ] operators/sensors/transfers
- [ ] unit tests with mocks
- [ ] integration tests if applicable
- [ ] example dags for examples and their use (examples, howtos, system tests)
- [ ] howto guides
- [ ] relation with backport providers.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13193: Add Prerequisites that new provider package should fulfils
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13193:
URL: https://github.com/apache/airflow/pull/13193#issuecomment-749122868
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] TobKed commented on a change in pull request #13193: Add Prerequisites that new provider package should fulfils
Posted by GitBox <gi...@apache.org>.
TobKed commented on a change in pull request #13193:
URL: https://github.com/apache/airflow/pull/13193#discussion_r557247529
##########
File path: docs/apache-airflow-providers/index.rst
##########
@@ -224,6 +224,64 @@ Apache projects. As a community, we provide all the software for free and this w
change. What 3rd-party developers are doing is not under control of Apache Airflow community.
+Prerequisites that new provider package should fulfill
+""""""""""""""""""""""""""""""""""""""""""""""""""""""
+
+* Directory structure:
+
+ .. code-block:: bash
+
+ airflow/airflow/providers/some_provider
+ ├── BACKPORT_PROVIDER_README.md
+ ├── README.md
+ ├── __init__.py
+ ├── example_dags
+ │ ├── __init__.py
+ │ └── example_some_provider.py
+ ├── hooks
+ │ ├── __init__.py
+ │ └── some_provider.py
+ ├── operators
+ │ ├── __init__.py
+ │ └── some_provider.py
+ ├── sensors
+ │ ├── __init__.py
+ │ └── some_provider.py
+ ├── transfers
+ │ ├── __init__.py
+ │ └── some_provider.py
+ └── provider.yaml
+
+ tests/providers/some_provider
+ ├── __init__.py
+ ├── hooks
+ │ ├── __init__.py
+ │ └── test_some_provider.py
+ ├── operators
+ │ ├── __init__.py
+ │ ├── test_some_provider.py
+ │ └── test_some_provider_system.py
+ ├── sensors
+ │ ├── __init__.py
+ │ └── test_some_provider.py
+ └── transfers
+ ├── __init__.py
+ └── test_some_provider.py
+
+* Add documentation in ``docs/apache-airflow-providers-some-provider/index.rst``
+
+* Update files:
+
+ * ``airflow/CONTRIBUTING.rst``:
+
+ * extras
+ * provider packages
+
+ * ``airflow/providers/dependencies.json``
Review comment:
Updated in https://github.com/apache/airflow/pull/13193/commits/0e966708f16816f8d1215efd29e1b355fdc31582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #13193: Add Prerequisites that new provider package should fulfils
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #13193:
URL: https://github.com/apache/airflow/pull/13193
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13193: Add Prerequisites that new provider package should fulfils
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13193:
URL: https://github.com/apache/airflow/pull/13193#issuecomment-792387977
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13193: Add Prerequisites that new provider package should fulfils
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13193:
URL: https://github.com/apache/airflow/pull/13193#discussion_r546852445
##########
File path: docs/apache-airflow-providers/index.rst
##########
@@ -224,6 +224,64 @@ Apache projects. As a community, we provide all the software for free and this w
change. What 3rd-party developers are doing is not under control of Apache Airflow community.
+Prerequisites that new provider package should fulfill
+""""""""""""""""""""""""""""""""""""""""""""""""""""""
+
+* Directory structure:
+
+ .. code-block:: bash
+
+ airflow/airflow/providers/some_provider
+ ├── BACKPORT_PROVIDER_README.md
+ ├── README.md
+ ├── __init__.py
+ ├── example_dags
+ │ ├── __init__.py
+ │ └── example_some_provider.py
+ ├── hooks
+ │ ├── __init__.py
+ │ └── some_provider.py
+ ├── operators
+ │ ├── __init__.py
+ │ └── some_provider.py
+ ├── sensors
+ │ ├── __init__.py
+ │ └── some_provider.py
+ ├── transfers
+ │ ├── __init__.py
+ │ └── some_provider.py
+ └── provider.yaml
+
+ tests/providers/some_provider
+ ├── __init__.py
+ ├── hooks
+ │ ├── __init__.py
+ │ └── test_some_provider.py
+ ├── operators
+ │ ├── __init__.py
+ │ ├── test_some_provider.py
+ │ └── test_some_provider_system.py
+ ├── sensors
+ │ ├── __init__.py
+ │ └── test_some_provider.py
+ └── transfers
+ ├── __init__.py
+ └── test_some_provider.py
+
+* Add documentation in ``docs/apache-airflow-providers-some-provider/index.rst``
+
+* Update files:
+
+ * ``airflow/CONTRIBUTING.rst``:
+
+ * extras
+ * provider packages
+
+ * ``airflow/providers/dependencies.json``
Review comment:
This should happen automatically by pre-commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] TobKed commented on pull request #13193: Add Prerequisites that new provider package should fulfils
Posted by GitBox <gi...@apache.org>.
TobKed commented on pull request #13193:
URL: https://github.com/apache/airflow/pull/13193#issuecomment-760067422
Thanks @potiuk! I rebased nad made small update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org