You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2020/01/08 05:44:33 UTC

[GitHub] [incubator-livy] runzhiwang commented on a change in pull request #268: [LIVY-735][RSC] Fix rpc channel closed when multi clients connect to one driver

runzhiwang commented on a change in pull request #268: [LIVY-735][RSC] Fix rpc channel closed when multi clients connect to one driver
URL: https://github.com/apache/incubator-livy/pull/268#discussion_r364071623
 
 

 ##########
 File path: rsc/src/main/java/org/apache/livy/rsc/rpc/Rpc.java
 ##########
 @@ -238,6 +244,166 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
     });
   }
 
+  /**
+   * Override this to add a name to the dispatcher, for debugging purposes.
 
 Review comment:
   Yes, you are right. This Override  comment was copied from RpcDispatcher.java, which also does not override anything. I will remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services