[GitHub] [superset] michael-s-molina commented on issue #24271: [SIP-96] Proposal for adding a notification feature

["michael-s-molina (via GitHub)" <gi...@apache.org>]

michael-s-molina commented on issue #24271:
URL: https://github.com/apache/superset/issues/24271#issuecomment-1587801184

   Thanks for the SIP! Some thoughts:
   
   - It would be a good idea to get @kasiazjc's input on the screens.
   - I really like @villebro's idea of different types of notifications. A banner would be helpful for critical messages that need to persist while an event is happening.
   - Regarding the HTML sanitization, you can always extend the default schema with `HTML_SANITIZATION_OVERRIDES` and keep it safe with a well defined Content Security Policy (CSP). The important part here is that notifications should respect these settings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org