You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/02/16 15:42:37 UTC

Review Request 56760: RANGER-1388: Improve error messages in AtlasKafkaResourceMapper

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56760/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-1388
    https://issues.apache.org/jira/browse/RANGER-1388


Repository: ranger


Description
-------

The error messages in AtlasKafkaResourceMapper are a bit misleading. If the qualified name does not contains "@" then the error message reports that the qualified name attribute is not found. It would be more accurate to report that the cluster name is not found in the qualified name attribute.


Diffs
-----

  tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java 9f1fc2d 

Diff: https://reviews.apache.org/r/56760/diff/


Testing
-------


Thanks,

Colm O hEigeartaigh


Re: Review Request 56760: RANGER-1388: Improve error messages in AtlasKafkaResourceMapper

Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56760/#review168699
-----------------------------------------------------------


Ship it!




Ship It!

- Qiang Zhang


On \u4e8c\u6708 16, 2017, 3:42 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56760/
> -----------------------------------------------------------
> 
> (Updated \u4e8c\u6708 16, 2017, 3:42 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1388
>     https://issues.apache.org/jira/browse/RANGER-1388
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The error messages in AtlasKafkaResourceMapper are a bit misleading. If the qualified name does not contains "@" then the error message reports that the qualified name attribute is not found. It would be more accurate to report that the cluster name is not found in the qualified name attribute.
> 
> 
> Diffs
> -----
> 
>   tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java 9f1fc2d 
> 
> 
> Diff: https://reviews.apache.org/r/56760/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>