[jira] [Work logged] (ARTEMIS-4962) possible NRE in FilterImpl

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-4962?focusedWorklogId=933007&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-933007 ]

ASF GitHub Bot logged work on ARTEMIS-4962:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Sep/24 14:06
            Start Date: 03/Sep/24 14:06
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on PR #5193:
URL: https://github.com/apache/activemq-artemis/pull/5193#issuecomment-2326621005

   Change seemed ok but needed testing. I pushed another commit adding one, see what you think.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 933007)
    Time Spent: 20m  (was: 10m)

> possible NRE in FilterImpl
> --------------------------
>
>                 Key: ARTEMIS-4962
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4962
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Ekaterina Zilotina
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In FilterImpl class there is potential *NullReferenceException* in private method *GetHeaderFieldValue()* ([line 169|https://github.com/apache/activemq-artemis/blob/75f17ba64df10663a14fcc85bcb5398d23941b6d/artemis-server/src/main/java/org/apache/activemq/artemis/core/filter/impl/FilterImpl.java#L169]).
> When condition in line 161 is true and condition in line 164 is false null return value of *msg.getUserID()* (cause in line 161 was true condition) derefers in 169. Is it absolutely true that in complex these conditions must only works as "true+true" or be skipped by first "false"? Does this part of code need another check before 169 line?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@activemq.apache.org
For additional commands, e-mail: issues-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact