You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by br...@apache.org on 2005/06/04 06:19:14 UTC
svn commit: r179938 - in /maven/maven-1/plugins/trunk/changelog:
src/main/org/apache/maven/cvslib/CvsChangeLogGenerator.java
src/test/org/apache/maven/cvslib/CvsChangeLogGeneratorTest.java
xdocs/changes.xml
Author: brett
Date: Fri Jun 3 21:19:11 2005
New Revision: 179938
URL: http://svn.apache.org/viewcvs?rev=179938&view=rev
Log:
PR: MPCHANGELOG-47
quote argument on Windows
Modified:
maven/maven-1/plugins/trunk/changelog/src/main/org/apache/maven/cvslib/CvsChangeLogGenerator.java
maven/maven-1/plugins/trunk/changelog/src/test/org/apache/maven/cvslib/CvsChangeLogGeneratorTest.java
maven/maven-1/plugins/trunk/changelog/xdocs/changes.xml
Modified: maven/maven-1/plugins/trunk/changelog/src/main/org/apache/maven/cvslib/CvsChangeLogGenerator.java
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/changelog/src/main/org/apache/maven/cvslib/CvsChangeLogGenerator.java?rev=179938&r1=179937&r2=179938&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/changelog/src/main/org/apache/maven/cvslib/CvsChangeLogGenerator.java (original)
+++ maven/maven-1/plugins/trunk/changelog/src/main/org/apache/maven/cvslib/CvsChangeLogGenerator.java Fri Jun 3 21:19:11 2005
@@ -197,7 +197,12 @@
protected String getScmDateArgument(Date before, Date to)
{
SimpleDateFormat outputDate = new SimpleDateFormat("yyyy-MM-dd");
- return "-d " + outputDate.format(before) + "<" + outputDate.format(to);
+ String cmd = outputDate.format(before) + "<" + outputDate.format(to);
+ if ( System.getProperty( "os.name" ).startsWith( "Windows" ) )
+ {
+ cmd = "\"" + cmd + "\"";
+ }
+ return "-d " + cmd;
}
/**
Modified: maven/maven-1/plugins/trunk/changelog/src/test/org/apache/maven/cvslib/CvsChangeLogGeneratorTest.java
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/changelog/src/test/org/apache/maven/cvslib/CvsChangeLogGeneratorTest.java?rev=179938&r1=179937&r2=179938&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/changelog/src/test/org/apache/maven/cvslib/CvsChangeLogGeneratorTest.java (original)
+++ maven/maven-1/plugins/trunk/changelog/src/test/org/apache/maven/cvslib/CvsChangeLogGeneratorTest.java Fri Jun 3 21:19:11 2005
@@ -205,6 +205,10 @@
assertEquals("index " + index + ": clArgs.length", expected.length, clArgs.length);
for (int i = 0; i < expected.length; i++)
{
+ if ( clArgs[i].startsWith( "-d \"" ) )
+ {
+ clArgs[i] = "-d " + clArgs[i].substring( 4, clArgs[i].length() - 1 );
+ }
assertEquals("index " + index + ": clArgs[" + i + "]", expected[i], clArgs[i]);
}
}
Modified: maven/maven-1/plugins/trunk/changelog/xdocs/changes.xml
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/changelog/xdocs/changes.xml?rev=179938&r1=179937&r2=179938&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/changelog/xdocs/changes.xml (original)
+++ maven/maven-1/plugins/trunk/changelog/xdocs/changes.xml Fri Jun 3 21:19:11 2005
@@ -26,6 +26,7 @@
</properties>
<body>
<release version="1.8-SNAPSHOT" date="in SVN">
+ <action dev="brett" type="fix" issue="MPCHANGELOG-47">Quote argument with < in it on Windows for the CVS provider - required if using CVSNT</action>
<action dev="brett" type="fix" issue="MPCHANGELOG-55">Fix problem parsing revisions on Linux introduced by MPCHANGELOG-29</action>
<action dev="brett" type="fix" issue="MPCHANGELOG-63" due-to="David Jackman">Add the ability to show several sets of changes</action>
<action dev="brett" type="fix" issue="MPCHANGELOG-23">Guess factory from connection</action>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org