You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Tiendq <gi...@git.apache.org> on 2014/04/22 12:42:14 UTC

[GitHub] cordova-plugin-statusbar pull request: Comment out line 105: [self...

GitHub user Tiendq opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/5

    Comment out line 105: [self styleLightContent:nil]; // match default bac...

    ...kgroundColor of #000000
    
    Don't need it, just leave it as is. If we select Default in Xcode project settings then status bar text is black during app starting then changed to white because this line. Comment out this line will leave status bar text always black (as default).
    
    [self styleLightContent:nil]; // match default backgroundColor of #000000

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Tiendq/cordova-plugin-statusbar master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
    
----
commit ee15cb63f78efa2d09406d3ee5510847592bddaf
Author: Tiendq <ti...@gmail.com>
Date:   2014-04-22T10:39:19Z

    Comment out line 105: [self styleLightContent:nil]; // match default backgroundColor of #000000
    
    Don't need it, just leave it as is. If we select Default in Xcode project settings then status bar text is black during app starting then changed to white because this line. Comment out this line will leave status bar text always black (as default).
    
    [self styleLightContent:nil]; // match default backgroundColor of #000000

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: Comment out line 105: [self...

Posted by Tiendq <gi...@git.apache.org>.
Github user Tiendq commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/5#issuecomment-41116685
  
    I got it, so it needs a check here and only apply this line when StatusBarOverlaysWebView is false.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: Comment out line 105: [self...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-statusbar/pull/5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: Comment out line 105: [self...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/5#issuecomment-41101919
  
    The reason this line is there is, when the preference StatusBarOverlaysWebView is set to false (by default it is true), you can still see the text, because of the black background.
    
    To see what I mean:
    1. Create a new project
    2. Install the StatusBar plugin
    3. Change the preference to:
    ```
        <preference name="StatusBarOverlaysWebView" value="false" />
    ```
    
    If your patch was applied, the statusbar text will not be visible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---