You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/13 07:08:32 UTC
[GitHub] [inlong] vernedeng opened a new pull request, #5873: [INLONG-5839][Sort] Add SortStandalone option in start script
vernedeng opened a new pull request, #5873:
URL: https://github.com/apache/inlong/pull/5873
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #5839
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] github-actions[bot] commented on pull request #5873: [INLONG-5839][Sort] Add SortStandalone option in start script
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5873:
URL: https://github.com/apache/inlong/pull/5873#issuecomment-1495228297
This PR is stale because it has been open for 60 days with no activity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5873: [INLONG-5839][Sort] Add SortStandalone option in start script
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5873:
URL: https://github.com/apache/inlong/pull/5873#discussion_r990721075
##########
inlong-distribution/src/main/assemblies/release.xml:
##########
@@ -96,6 +96,20 @@
<outputDirectory>inlong-tubemq-manager</outputDirectory>
</fileSet>
+ <!-- package InLong-Sort-Standalone-->
+ <fileSet>
+ <directory>../inlong-sort-standalone/sort-standalone-dist/target/apache-inlong-sort-standalone-${project.version}-bin</directory>
+ <outputDirectory>inlong-sort-standalone</outputDirectory>
+ </fileSet>
+ <!-- module's 3td-licenses, notices-->
Review Comment:
```suggestion
<!-- module's 3rd-licenses, notices -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on a diff in pull request #5873: [INLONG-5839][Sort] Add SortStandalone option in start script
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #5873:
URL: https://github.com/apache/inlong/pull/5873#discussion_r990741060
##########
bin/inlong-daemon:
##########
@@ -32,6 +32,7 @@ command_help() {
dashboard Run a Dashboard Service
dataproxy Run a Dataproxy Service
agent Run a Agent Service
+ sortstandalone Run a Sortstandalone Service
Review Comment:
Run a Sortstandalone Service
->
Run a Sort Standalone Service
Since `Sortstandalone` is not a readable word.
##########
conf/inlong.conf:
##########
@@ -63,4 +63,14 @@ agent_port=8008
# audit proxy IP
audit_proxys_ip=127.0.0.1
# audit proxy Port
-audit_proxys_port=10081
\ No newline at end of file
+audit_proxys_port=10081
+
Review Comment:
a more empty line.
##########
conf/inlong.conf:
##########
@@ -63,4 +63,14 @@ agent_port=8008
# audit proxy IP
audit_proxys_ip=127.0.0.1
# audit proxy Port
-audit_proxys_port=10081
\ No newline at end of file
+audit_proxys_port=10081
+
+############## SortStandalone Configuration ##############
+sortstandalone_ip=127.0.0.1
+sortstandalone_port=8088
+# sort-standalone config type, file or manager
+sortstandalone_config_type=file
+# sort-standalone config file name
+sortstandalone_config_file_name=SortClusterConfig.conf
Review Comment:
'sortstandalone_config_file_name ' is redundant. It's better to remove it.
##########
bin/inlong-daemon:
##########
@@ -149,6 +158,8 @@ start_inlong_all() {
start_inlong_dataproxy
# start inlong agent
start_inlong_agent
+ # start inlong sortstandalone
+ start_inlong_sortstandalone
Review Comment:
start inlong sortstandalone
->
start inlong sort standalone
##########
conf/inlong.conf:
##########
@@ -63,4 +63,14 @@ agent_port=8008
# audit proxy IP
audit_proxys_ip=127.0.0.1
# audit proxy Port
-audit_proxys_port=10081
\ No newline at end of file
+audit_proxys_port=10081
+
+############## SortStandalone Configuration ##############
+sortstandalone_ip=127.0.0.1
+sortstandalone_port=8088
+# sort-standalone config type, file or manager
Review Comment:
please add more information about the different types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng closed pull request #5873: [INLONG-5839][Sort] Add SortStandalone option in start script
Posted by "vernedeng (via GitHub)" <gi...@apache.org>.
vernedeng closed pull request #5873: [INLONG-5839][Sort] Add SortStandalone option in start script
URL: https://github.com/apache/inlong/pull/5873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #5873: [INLONG-5839][Sort] Add SortStandalone option in start script
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #5873:
URL: https://github.com/apache/inlong/pull/5873#issuecomment-1272722764
if sort-standalone add to the binary package, it will exceed the limit size, and here we need to think more about how to reuse the dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org