You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/05/05 14:02:15 UTC

[GitHub] wu-sheng commented on issue #1174: Duplicate Service Name And application id is 0

wu-sheng commented on issue #1174: Duplicate Service Name And application id is 0
URL: https://github.com/apache/incubator-skywalking/issues/1174#issuecomment-386807747
 
 
   @candyleer Thanks for reporting this issue. The reason parentApplicationInstanceId is empty, because there is no need. For across thread, applicationInstanceId of parent is same as the current applicationInstanceId. 
   
   Of course, this is a little harm to add this field into CROSS_THREAD REF. Just send one or two more bytes. So I think the easier way is to accept your proposal. Please send the pull request as soon as possible.
   
   We are going to froze codes for preparing the next release.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services