[GitHub] [arrow] kevingurney commented on a diff in pull request #36731: GH-36652: [MATLAB] Initialize the `Type` property of `arrow.array.Array` subclasses from existing proxy ids

["kevingurney (via GitHub)" <gi...@apache.org>]

kevingurney commented on code in PR #36731:
URL: https://github.com/apache/arrow/pull/36731#discussion_r1265727301


##########
matlab/src/matlab/+arrow/+internal/+proxy/validate.m:
##########
@@ -0,0 +1,29 @@
+% Licensed to the Apache Software Foundation (ASF) under one or more
+% contributor license agreements.  See the NOTICE file distributed with
+% this work for additional information regarding copyright ownership.
+% The ASF licenses this file to you under the Apache License, Version
+% 2.0 (the "License"); you may not use this file except in compliance
+% with the License.  You may obtain a copy of the License at
+%
+%   http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS,
+% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+% implied.  See the License for the specific language governing
+% permissions and limitations under the License.
+
+function validate(proxy, expectedName)
+%VALIDATE Throws an arrow:matlab:ProxyNameMismatch error if
+% proxy.Name and expectedName are not equal.
+    arguments
+        proxy(1, 1) libmexclass.proxy.Proxy
+        expectedName(1, 1) string
+    end
+
+    if proxy.Name ~= expectedName
+        errid = "arrow:matlab:ProxyNameMismatch";

Review Comment:
   I think we can drop the "matlab" prat of the error identifier here.
   
   For example:
   
   "arrow:matlab:ProxyNameMismatch" -> "arrow:proxy:ProxyNameMismatch"



##########
matlab/src/matlab/+arrow/+type/boolean.m:
##########
@@ -0,0 +1,20 @@
+% Licensed to the Apache Software Foundation (ASF) under one or more
+% contributor license agreements.  See the NOTICE file distributed with
+% this work for additional information regarding copyright ownership.
+% The ASF licenses this file to you under the Apache License, Version
+% 2.0 (the "License"); you may not use this file except in compliance
+% with the License.  You may obtain a copy of the License at
+%
+%   http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS,
+% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+% implied.  See the License for the specific language governing
+% permissions and limitations under the License.
+function booleanType = boolean()

Review Comment:
   For consistency across the different type construction functions - it might make sense to name the output something generic like `type`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org