[jira] [Commented] (TAJO-974) Eliminate unexpected case condition in SubQuery

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073332#comment-14073332 ] 

ASF GitHub Bot commented on TAJO-974:
-------------------------------------

GitHub user babokim opened a pull request:

    https://github.com/apache/tajo/pull/93

    TAJO-974: Eliminate unexpected case condition in SubQuery

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/babokim/tajo TAJO-974

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/93.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #93
    
----
commit 6463f8d7299f582ab8806b57691f5c3766803ebc
Author: 김형준 <ba...@babokim-macbook-pro.local>
Date:   2014-07-24T15:49:32Z

    TAJO-974: Eliminate unexpected case condition in SubQuery

commit 5542dc9a0a2382b877a0ffc2e314e2a8f2823426
Author: 김형준 <ba...@babokim-macbook-pro.local>
Date:   2014-07-24T15:49:57Z

    Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo

----


> Eliminate unexpected case condition in SubQuery
> -----------------------------------------------
>
>                 Key: TAJO-974
>                 URL: https://issues.apache.org/jira/browse/TAJO-974
>             Project: Tajo
>          Issue Type: Bug
>          Components: distributed query plan
>            Reporter: Hyunsik Choi
>            Assignee: Hyoungjun Kim
>             Fix For: 0.9.0
>
>
> Please take a loot at the below code. In SubQuery::calculateShuffleOutputNum() method, if-condition will be passed through the unexpected case if the plan is neither group by and join. In current implementation, distinct group-by operator can cause this case. Actually, the below code is messy. We need to directly handle distinct group by and clean up the below code.
> {code:title="SubQuery::calculateShuffleOutputNum()"}
> } else {
>         LOG.info("============>>>>> Unexpected Case! <<<<<================");
>         long volume = getInputVolume(subQuery.masterPlan, subQuery.context, subQuery.block);
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)