You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/02/10 03:17:46 UTC
[GitHub] [submarine] liuxunorg commented on a change in pull request #176:
SUBMARINE-381. Temporarily disable interpreter module
liuxunorg commented on a change in pull request #176: SUBMARINE-381. Temporarily disable interpreter module
URL: https://github.com/apache/submarine/pull/176#discussion_r376853898
##########
File path: bin/submarine-daemon.sh
##########
@@ -39,7 +39,6 @@ SUBMARINE_SERVER_MAIN=org.apache.submarine.server.SubmarineServer
JAVA_OPTS+="${SUBMARINE_SERVER_JAVA_OPTS} ${SUBMARINE_SERVER_MEM} -Dsubmarine.log.file=${SUBMARINE_SERVER_LOGFILE}"
add_jar_in_dir "${BIN}/../lib"
-add_jar_in_dir "${BIN}/../lib/submitter"
Review comment:
No, this is an invalid code.
Because the submitter is loaded dynamically at runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org