[GitHub] [lucene] gsmiller commented on a change in pull request #255: LUCENE-5309: Optimize facet counting for single-valued SSDV / StringValueFacetCounts

[GitBox <gi...@apache.org>]

gsmiller commented on a change in pull request #255:
URL: https://github.com/apache/lucene/pull/255#discussion_r694149519



##########
File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/ConcurrentSortedSetDocValuesFacetCounts.java
##########
@@ -103,7 +105,7 @@ public FacetResult getTopChildren(int topN, String dim, String... path) throws I
     return getDim(dim, ordRange, topN);
   }
 
-  private final FacetResult getDim(String dim, OrdRange ordRange, int topN) throws IOException {
+  private FacetResult getDim(String dim, OrdRange ordRange, int topN) throws IOException {

Review comment:
       @mikemccand no need to mark `private` methods as final since they're not visible for sub-classes to override




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org