You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2023/05/01 13:45:46 UTC
[GitHub] [accumulo] dlmarion commented on a diff in pull request #3332: WIP - Add an optional fenced range to Tablet files
dlmarion commented on code in PR #3332:
URL: https://github.com/apache/accumulo/pull/3332#discussion_r1181581407
##########
server/base/src/main/java/org/apache/accumulo/server/fs/FileManager.java:
##########
@@ -244,8 +244,9 @@ private List<String> takeOpenFiles(Collection<String> files,
return filesToOpen;
}
- private Map<FileSKVIterator,String> reserveReaders(KeyExtent tablet, Collection<String> files,
- boolean continueOnFailure, CacheProvider cacheProvider) throws IOException {
+ private Map<FileSKVIterator,TabletFile> reserveReaders(KeyExtent tablet,
+ Collection<TabletFile> files, boolean continueOnFailure, CacheProvider cacheProvider)
+ throws IOException {
if (!tablet.isMeta() && files.size() >= maxOpen) {
Review Comment:
`files` may contain multiple instances that reference the same underlying file, just with a different range, right? This would seem to me that there is a higher probability that users will hit the limit set by `TSERV_SCAN_MAX_OPENFILES` and other file limit properties. I think we need to take this into account when checking the number of open files against their respective properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org