You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/09 21:10:24 UTC
[GitHub] [netbeans] KacerCZ opened a new pull request #2659: [NETBEANS-5228] Enable 'return' breakpoint in PHP debugger
KacerCZ opened a new pull request #2659:
URL: https://github.com/apache/netbeans/pull/2659
https://issues.apache.org/jira/browse/NETBEANS-5228
Enables support for breakpoint on return from function in PHP debugger.
Originally disabled in 2008 because of bug in Xdebug, the bug was fixed in 2009.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a change in pull request #2659: [NETBEANS-5228] Enable 'return' breakpoint in PHP debugger
Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2659:
URL: https://github.com/apache/netbeans/pull/2659#discussion_r559087149
##########
File path: php/php.dbgp/src/org/netbeans/modules/php/dbgp/ui/DbgpMethodBreakpointPanel.java
##########
@@ -106,13 +104,10 @@ private void initComponents() {
layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
.addGroup(layout.createSequentialGroup()
.addContainerGap()
- .addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.TRAILING)
- .addGroup(layout.createSequentialGroup()
- .addComponent(myStopOnLbl)
- .addGap(31, 31, 31))
- .addGroup(layout.createSequentialGroup()
- .addComponent(myMethodLbl)
- .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED)))
+ .addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
Review comment:
Just a note - is the UI (layout) OK? Please, verify it. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2659: [NETBEANS-5228] Enable 'return' breakpoint in PHP debugger
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2659:
URL: https://github.com/apache/netbeans/pull/2659#issuecomment-759643744
OK, I added steps how to create this type of breakpoint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik merged pull request #2659: [NETBEANS-5228] Enable 'return' breakpoint in PHP debugger
Posted by GitBox <gi...@apache.org>.
tmysik merged pull request #2659:
URL: https://github.com/apache/netbeans/pull/2659
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on a change in pull request #2659: [NETBEANS-5228] Enable 'return' breakpoint in PHP debugger
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on a change in pull request #2659:
URL: https://github.com/apache/netbeans/pull/2659#discussion_r559125920
##########
File path: php/php.dbgp/src/org/netbeans/modules/php/dbgp/ui/DbgpMethodBreakpointPanel.java
##########
@@ -106,13 +104,10 @@ private void initComponents() {
layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
.addGroup(layout.createSequentialGroup()
.addContainerGap()
- .addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.TRAILING)
- .addGroup(layout.createSequentialGroup()
- .addComponent(myStopOnLbl)
- .addGap(31, 31, 31))
- .addGroup(layout.createSequentialGroup()
- .addComponent(myMethodLbl)
- .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED)))
+ .addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
Review comment:
Yes, it's changed because I fixed alignment of "Stop On" label.
This is dialog with this change:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2659: [NETBEANS-5228] Enable 'return' breakpoint in PHP debugger
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2659:
URL: https://github.com/apache/netbeans/pull/2659#issuecomment-761766554
@junichi11 @tmysik Thanks for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2659: [NETBEANS-5228] Enable 'return' breakpoint in PHP debugger
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2659:
URL: https://github.com/apache/netbeans/pull/2659#issuecomment-761744165
@KacerCZ
Just a note/question added, otherwise looks good to me. Please, let us know, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a change in pull request #2659: [NETBEANS-5228] Enable 'return' breakpoint in PHP debugger
Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2659:
URL: https://github.com/apache/netbeans/pull/2659#discussion_r559127292
##########
File path: php/php.dbgp/src/org/netbeans/modules/php/dbgp/ui/DbgpMethodBreakpointPanel.java
##########
@@ -106,13 +104,10 @@ private void initComponents() {
layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
.addGroup(layout.createSequentialGroup()
.addContainerGap()
- .addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.TRAILING)
- .addGroup(layout.createSequentialGroup()
- .addComponent(myStopOnLbl)
- .addGap(31, 31, 31))
- .addGroup(layout.createSequentialGroup()
- .addComponent(myMethodLbl)
- .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED)))
+ .addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
Review comment:
Great, thank you for letting me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists