You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2012/12/12 23:23:22 UTC

[jira] [Resolved] (THRIFT-1699) Native Union#read has extra read_field_end call

     [ https://issues.apache.org/jira/browse/THRIFT-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer resolved THRIFT-1699.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0
         Assignee: Jens Geyer

Committed. 
Thanks Kevin and Nathan!
                
> Native Union#read has extra read_field_end call
> -----------------------------------------------
>
>                 Key: THRIFT-1699
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1699
>             Project: Thrift
>          Issue Type: Bug
>          Components: Ruby - Library
>    Affects Versions: 0.8
>            Reporter: Kevin Radloff
>            Assignee: Jens Geyer
>             Fix For: 1.0
>
>         Attachments: rb-struct.diff, THRIFT-1699-remove-extra-read-field-end.patch
>
>
> The native implementation of the Union#read method has an extraneous call to read_field_end. This makes no difference to most protocols because read_field_end is a no-op, but it breaks JSON (in this case my own class, not the one in trunk), which does do something in this method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira