[jira] [Commented] (HADOOP-14734) add option to tag DDB table(s) created

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513651#comment-16513651 ] 

Steve Loughran commented on HADOOP-14734:
-----------------------------------------


* Production code LGTM
* needs a paragraph in s3guard.md ; ideally the {{hadoop s3guard create}} command example also to show how to set a tag property.

Test {{AbstractS3ATestBase}}

* Import ordering not quite what our under-enforced standards expect (org.apache.*) in its own section after the others
* rather than add new before/after clauses, override the setup /teardown methods of the parent class, call the base class ones.

I actually think we may want to skip the test entirely, and instead extend the HADOOP-14918 tests once they are in. That's creating a real DDB table, so we can just extend it to tag the table with some tags we make up, then do the verification in {{testTableTagging}} on the table it has created.

Once this is in, we can think about adding it to the {{hadoop s3guard create}} command; I'd imagine a {{-tag key=value}} list of tags. As it can be done via the -D operation today, that's not critical.

> add option to tag DDB table(s) created
> --------------------------------------
>
>                 Key: HADOOP-14734
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14734
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.0.0-beta1
>            Reporter: Steve Loughran
>            Assignee: Abraham Fine
>            Priority: Minor
>         Attachments: HADOOP-14734-001.patch, HADOOP-14734-002.patch, HADOOP-14734-003.patch
>
>
> Many organisations have a "no untagged" resource policy; s3guard runs into this when a table is created untagged. If there's a strict "delete untagged resources" policy, the tables will go without warning.
> Proposed: we add an option which can be used to declare the tags for a table when created, use it in creation. No need to worry about updating/viewing tags, as the AWS console can do that



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org