[GitHub] pritidesai commented on issue #383: Delete openwhisk credentials from manifest and deployment files

[gi...@git.apache.org]

pritidesai commented on issue #383: Delete openwhisk credentials from manifest and deployment files
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/383#issuecomment-326372968
 
 
   Confirming that we no longer have any hardcoded credential in manifest and deployment file except `./tests/usecases/webhook/deployment.yml` which just shows the usage and will be removed with issue #359. Closing this issue. 
   
   ```
    [762] ->grep -r "namespace" . --include=manifest.*
   
    [762] -> grep -r "credential" . --include=manifest.*
   
    [763] -> grep -r "apiHost" . --include=manifest.*
   
    [764] -> grep -r "apihost" . --include=manifest.*
   
    [765] -> grep -r "namespace" . --include=deployment.*
   ./tests/src/integration/zipaction/deployment.yml:      namespace: guest
   ./tests/usecases/alarmtrigger/deployment.yaml:    namespace: _
   ./tests/usecases/badyaml/deployment.yaml:  namespace: _
   ./tests/usecases/data-processing-app/deployment.yaml:  namespace: _
   ./tests/usecases/defaulttest-bindings/deployment.yaml:  namespace: _
   ./tests/usecases/openstack/deployment.yaml:  namespace: _
   ./tests/usecases/triggerrule/deployment.yml:      namespace: guest
   ./tests/usecases/webhook/deployment.yml:  namespace: _                          # TODO: REPLACE IT with the namespace used in OpenWhisk server
   ./tests/usecases/whiskbot/deployment.yaml:  namespace: mynamespace
   
    [766] -> grep -r "credential" . --include=deployment.*
   ./tests/usecases/webhook/deployment.yml:  credential: c82b7b9d-296a-4b14        # TODO: REPLACE IT with the credential to access OpenWhisk server
   
    [768] -> grep -r "apihost" . --include=deployment.*
   
    [769] -> grep -r "apiHost" . --include=deployment.*
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services