You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/29 16:08:40 UTC

[GitHub] [airflow] uranusjr commented on pull request #16678: Serialize dag timezone to a tzname or offset

uranusjr commented on pull request #16678:
URL: https://github.com/apache/airflow/pull/16678#issuecomment-870730096


   Nothing more from me for now, but one thing for the future:
   
   > > The risk is that someone uses some custom datetime.tzinfo with a custom name with no equivalent in pendulum
   > 
   > I think so long as we document "don't do this" I'm okay wit this. The chance of someone creating a custom timezone seems _very_ slim given Airflow's typical users.
   
   We’ll probably need to revisit this when 3.10 is out (and supported by Airflow) since that will become the most obvious tzinfo implementation instead of `pendulum.Timzeon`. A follow-up issue tracking `zoneinfo.Zoneinfo` compatibility (and potentially an eventual switch to it from pendulum) would be nice to have.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org