You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Christian Schneider (JIRA)" <ji...@apache.org> on 2012/07/05 16:49:33 UTC
[jira] [Created] (KARAF-1628) Make client indepenent of console
Christian Schneider created KARAF-1628:
------------------------------------------
Summary: Make client indepenent of console
Key: KARAF-1628
URL: https://issues.apache.org/jira/browse/KARAF-1628
Project: Karaf
Issue Type: Improvement
Reporter: Christian Schneider
Assignee: Christian Schneider
Fix For: 3.0.0
The client module currently depends on the console module but only uses the TerminalFactory from it and the karaf.key.
So I would like to change the client to only depend on jansi, jline, sshd and mina. The only question is where to get the karaf.key from.
There are three possible solutions:
1. Create a module for the key. This module could also contain the code to load the key and setup the agent. Client and console could then depend on this module
2. Put the key in etc e.g. in the file karaf.key. So client and console could simply read from that location
3. Let e.g. client push the key into a separate file in maven (attach-artifact). So we can then easily depend on it from client and console.
I prefer solution 1 as it can be extended to completely remove the agent code from console using org.apache.felix.gogo.api.CommandSessionListener. So the new module could add the agent to the session easily.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1628) Make client indepenent of console
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409262#comment-13409262 ]
Christian Schneider commented on KARAF-1628:
--------------------------------------------
@Guillaume is the key really copied for the shell.ssh module I could not find any reference to that.
I also think copying the key at build time makes sense. How about putting the key into the client module which is the smallest. There I would use the build helper to attach to deploy the key separately. So I can conveniently copy it over in the console without depending on the whole client. This way we have no duplication in the source tree and still have minimal dependencies. We could also leave the key in console if you prefer and do the same the other way round.
> Make client indepenent of console
> ---------------------------------
>
> Key: KARAF-1628
> URL: https://issues.apache.org/jira/browse/KARAF-1628
> Project: Karaf
> Issue Type: Improvement
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 3.0.0
>
>
> The client module currently depends on the console module but only uses the TerminalFactory from it and the karaf.key.
> So I would like to change the client to only depend on jansi, jline, sshd and mina. The only question is where to get the karaf.key from.
> There are three possible solutions:
> 1. Create a module for the key. This module could also contain the code to load the key and setup the agent. Client and console could then depend on this module
> 2. Put the key in etc e.g. in the file karaf.key. So client and console could simply read from that location
> 3. Let e.g. client push the key into a separate file in maven (attach-artifact). So we can then easily depend on it from client and console.
> I prefer solution 1 as it can be extended to completely remove the agent code from console using org.apache.felix.gogo.api.CommandSessionListener. So the new module could add the agent to the session easily.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1628) Make client indepenent of console
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409256#comment-13409256 ]
Guillaume Nodet commented on KARAF-1628:
----------------------------------------
I'd rather have the simplest option which is to copy the key file inside the jar at build time while still having a single key file in the source tree. That's what is currently done for the ssh module and I think that's fine. Creating a maven module for a single file is overkill imo.
Note that it's what currently done with some config files in the instance/core module (which copy some files from the assembly iirc).
> Make client indepenent of console
> ---------------------------------
>
> Key: KARAF-1628
> URL: https://issues.apache.org/jira/browse/KARAF-1628
> Project: Karaf
> Issue Type: Improvement
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 3.0.0
>
>
> The client module currently depends on the console module but only uses the TerminalFactory from it and the karaf.key.
> So I would like to change the client to only depend on jansi, jline, sshd and mina. The only question is where to get the karaf.key from.
> There are three possible solutions:
> 1. Create a module for the key. This module could also contain the code to load the key and setup the agent. Client and console could then depend on this module
> 2. Put the key in etc e.g. in the file karaf.key. So client and console could simply read from that location
> 3. Let e.g. client push the key into a separate file in maven (attach-artifact). So we can then easily depend on it from client and console.
> I prefer solution 1 as it can be extended to completely remove the agent code from console using org.apache.felix.gogo.api.CommandSessionListener. So the new module could add the agent to the session easily.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1628) Make client indepenent of console
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409248#comment-13409248 ]
Christian Schneider commented on KARAF-1628:
--------------------------------------------
I will defer the key issue for a bit and already commit the client changes to make it independent of console. Currently I duplicate the key in the client project. I will soon fix that with one of the options above.
> Make client indepenent of console
> ---------------------------------
>
> Key: KARAF-1628
> URL: https://issues.apache.org/jira/browse/KARAF-1628
> Project: Karaf
> Issue Type: Improvement
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 3.0.0
>
>
> The client module currently depends on the console module but only uses the TerminalFactory from it and the karaf.key.
> So I would like to change the client to only depend on jansi, jline, sshd and mina. The only question is where to get the karaf.key from.
> There are three possible solutions:
> 1. Create a module for the key. This module could also contain the code to load the key and setup the agent. Client and console could then depend on this module
> 2. Put the key in etc e.g. in the file karaf.key. So client and console could simply read from that location
> 3. Let e.g. client push the key into a separate file in maven (attach-artifact). So we can then easily depend on it from client and console.
> I prefer solution 1 as it can be extended to completely remove the agent code from console using org.apache.felix.gogo.api.CommandSessionListener. So the new module could add the agent to the session easily.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (KARAF-1628) Make client indepenent of
console
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409262#comment-13409262 ]
Christian Schneider edited comment on KARAF-1628 at 7/9/12 8:17 AM:
--------------------------------------------------------------------
@Guillaume is the key really copied for the shell.ssh module? I could not find any reference to that.
I also think copying the key at build time makes sense. How about putting the key into the client module which is the smallest. There I would use the build helper to deploy the key separately. So I can conveniently copy it over in the console without depending on the whole client. This way we have no duplication in the source tree and still have minimal dependencies. We could also leave the key in console if you prefer and do the same the other way round.
was (Author: chris@die-schneider.net):
@Guillaume is the key really copied for the shell.ssh module I could not find any reference to that.
I also think copying the key at build time makes sense. How about putting the key into the client module which is the smallest. There I would use the build helper to attach to deploy the key separately. So I can conveniently copy it over in the console without depending on the whole client. This way we have no duplication in the source tree and still have minimal dependencies. We could also leave the key in console if you prefer and do the same the other way round.
> Make client indepenent of console
> ---------------------------------
>
> Key: KARAF-1628
> URL: https://issues.apache.org/jira/browse/KARAF-1628
> Project: Karaf
> Issue Type: Improvement
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 3.0.0
>
>
> The client module currently depends on the console module but only uses the TerminalFactory from it and the karaf.key.
> So I would like to change the client to only depend on jansi, jline, sshd and mina. The only question is where to get the karaf.key from.
> There are three possible solutions:
> 1. Create a module for the key. This module could also contain the code to load the key and setup the agent. Client and console could then depend on this module
> 2. Put the key in etc e.g. in the file karaf.key. So client and console could simply read from that location
> 3. Let e.g. client push the key into a separate file in maven (attach-artifact). So we can then easily depend on it from client and console.
> I prefer solution 1 as it can be extended to completely remove the agent code from console using org.apache.felix.gogo.api.CommandSessionListener. So the new module could add the agent to the session easily.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KARAF-1628) Make client indepenent of console
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider resolved KARAF-1628.
----------------------------------------
Resolution: Fixed
> Make client indepenent of console
> ---------------------------------
>
> Key: KARAF-1628
> URL: https://issues.apache.org/jira/browse/KARAF-1628
> Project: Karaf
> Issue Type: Improvement
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 3.0.0
>
>
> The client module currently depends on the console module but only uses the TerminalFactory from it and the karaf.key.
> So I would like to change the client to only depend on jansi, jline, sshd and mina. The only question is where to get the karaf.key from.
> There are three possible solutions:
> 1. Create a module for the key. This module could also contain the code to load the key and setup the agent. Client and console could then depend on this module
> 2. Put the key in etc e.g. in the file karaf.key. So client and console could simply read from that location
> 3. Let e.g. client push the key into a separate file in maven (attach-artifact). So we can then easily depend on it from client and console.
> I prefer solution 1 as it can be extended to completely remove the agent code from console using org.apache.felix.gogo.api.CommandSessionListener. So the new module could add the agent to the session easily.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira