You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/04 20:54:37 UTC

[GitHub] ttannis commented on a change in pull request #4760: URL shortner for dashboards

ttannis commented on a change in pull request #4760: URL shortner for dashboards
URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r179279931
 
 

 ##########
 File path: superset/assets/javascripts/components/URLShortLinkButton.jsx
 ##########
 @@ -25,20 +27,20 @@ export default class URLShortLinkButton extends React.Component {
   }
 
   getCopyUrl() {
-    const longUrl = getExploreLongUrl(this.props.latestQueryFormData);
+    const longUrl = (this.props.type === 'Dashboard') ? getDashboardLongUrl(this.props.context) : getExploreLongUrl(this.props.context);
 
 Review comment:
   Yeah, I noticed after uploading the effect on code coverage. I'll get to fixing that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services