You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2015/08/07 05:47:38 UTC
svn commit: r1694610 - in /commons/proper/codec/trunk/src:
main/java/org/apache/commons/codec/binary/
main/java/org/apache/commons/codec/language/bm/
main/java/org/apache/commons/codec/net/
test/java/org/apache/commons/codec/binary/ test/java/org/apach...
Author: ggregory
Date: Fri Aug 7 03:47:38 2015
New Revision: 1694610
URL: http://svn.apache.org/r1694610
Log:
Use final.
Modified:
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/CharSequenceUtils.java
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Languages.java
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/DaitchMokotoffSoundexTest.java
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/bm/PhoneticEngineRegressionTest.java
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/CharSequenceUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/CharSequenceUtils.java?rev=1694610&r1=1694609&r2=1694610&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/CharSequenceUtils.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/CharSequenceUtils.java Fri Aug 7 03:47:38 2015
@@ -56,8 +56,8 @@ public class CharSequenceUtils {
int tmpLen = length;
while (tmpLen-- > 0) {
- char c1 = cs.charAt(index1++);
- char c2 = substring.charAt(index2++);
+ final char c1 = cs.charAt(index1++);
+ final char c2 = substring.charAt(index2++);
if (c1 == c2) {
continue;
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Languages.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Languages.java?rev=1694610&r1=1694609&r2=1694610&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Languages.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Languages.java Fri Aug 7 03:47:38 2015
@@ -120,7 +120,7 @@ public class Languages {
} else {
final SomeLanguages sl = (SomeLanguages) other;
final Set<String> ls = new HashSet<String>(Math.min(languages.size(), sl.languages.size()));
- for (String lang : languages) {
+ for (final String lang : languages) {
if (sl.languages.contains(lang)) {
ls.add(lang);
}
@@ -138,7 +138,7 @@ public class Languages {
} else {
final SomeLanguages sl = (SomeLanguages) other;
final Set<String> ls = new HashSet<String>(languages);
- for (String lang : sl.languages) {
+ for (final String lang : sl.languages) {
ls.add(lang);
}
return from(ls);
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java?rev=1694610&r1=1694609&r2=1694610&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java Fri Aug 7 03:47:38 2015
@@ -171,7 +171,7 @@ public class PhoneticEngine {
private final Map<String, List<Rule>> finalRules;
private final CharSequence input;
- private PhonemeBuilder phonemeBuilder;
+ private final PhonemeBuilder phonemeBuilder;
private int i;
private final int maxPhonemes;
private boolean found;
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java?rev=1694610&r1=1694609&r2=1694610&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java Fri Aug 7 03:47:38 2015
@@ -250,7 +250,7 @@ public class QuotedPrintableCodec implem
* array of bytes to be encoded
* @return array of bytes containing quoted-printable data
*/
- public static final byte[] encodeQuotedPrintable(BitSet printable, final byte[] bytes) {
+ public static final byte[] encodeQuotedPrintable(final BitSet printable, final byte[] bytes) {
return encodeQuotedPrintable(printable, bytes, false);
}
@@ -270,7 +270,7 @@ public class QuotedPrintableCodec implem
* @return array of bytes containing quoted-printable data
* @since 1.10
*/
- public static final byte[] encodeQuotedPrintable(BitSet printable, final byte[] bytes, boolean strict) {
+ public static final byte[] encodeQuotedPrintable(BitSet printable, final byte[] bytes, final boolean strict) {
if (bytes == null) {
return null;
}
@@ -284,7 +284,7 @@ public class QuotedPrintableCodec implem
// encode up to buffer.length - 3, the last three octets will be treated
// separately for simplification of note #3
for (int i = 0; i < bytes.length - 3; i++) {
- int b = getUnsignedOctet(i, bytes);
+ final int b = getUnsignedOctet(i, bytes);
if (pos < SAFE_LENGTH) {
// up to this length it is safe to add any byte, encoded or not
pos += encodeByte(b, !printable.get(b), buffer);
Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java?rev=1694610&r1=1694609&r2=1694610&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java (original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java Fri Aug 7 03:47:38 2015
@@ -186,7 +186,7 @@ public class BaseNCodecTest {
};
// When
- byte actualPaddingByte = codec.pad;
+ final byte actualPaddingByte = codec.pad;
// Then
assertEquals(0x25, actualPaddingByte);
Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java?rev=1694610&r1=1694609&r2=1694610&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java (original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java Fri Aug 7 03:47:38 2015
@@ -232,7 +232,7 @@ public class HexTest {
@Test
public void testDecodeByteBufferOddCharacters() {
- ByteBuffer buffer = ByteBuffer.allocate(1);
+ final ByteBuffer buffer = ByteBuffer.allocate(1);
buffer.put((byte) 65);
try {
new Hex().decode(buffer);
Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/DaitchMokotoffSoundexTest.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/DaitchMokotoffSoundexTest.java?rev=1694610&r1=1694609&r2=1694610&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/DaitchMokotoffSoundexTest.java (original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/DaitchMokotoffSoundexTest.java Fri Aug 7 03:47:38 2015
@@ -36,11 +36,11 @@ public class DaitchMokotoffSoundexTest e
return new DaitchMokotoffSoundex();
}
- private String soundex(String source) {
+ private String soundex(final String source) {
return getStringEncoder().soundex(source);
}
- private String encode(String source) {
+ private String encode(final String source) {
return getStringEncoder().encode(source);
}
Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/bm/PhoneticEngineRegressionTest.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/bm/PhoneticEngineRegressionTest.java?rev=1694610&r1=1694609&r2=1694610&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/bm/PhoneticEngineRegressionTest.java (original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/bm/PhoneticEngineRegressionTest.java Fri Aug 7 03:47:38 2015
@@ -182,7 +182,7 @@ public class PhoneticEngineRegressionTes
// see CODEC-187
// comparison: http://stevemorse.org/census/soundex.html
- Map<String, String> args = new TreeMap<String, String>();
+ final Map<String, String> args = new TreeMap<String, String>();
args.put("nameType", "GENERIC");
args.put("ruleType", "APPROX");
Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java?rev=1694610&r1=1694609&r2=1694610&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java (original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java Fri Aug 7 03:47:38 2015
@@ -258,10 +258,10 @@ public class QuotedPrintableCodecTest {
final String qpdata = "If you believe that truth=3Dbeauty, then surely=20=\r\nmathematics is the most beautiful branch of philosophy.";
final String expected = "If you believe that truth=beauty, then surely mathematics is the most beautiful branch of philosophy.";
- QuotedPrintableCodec qpcodec = new QuotedPrintableCodec();
+ final QuotedPrintableCodec qpcodec = new QuotedPrintableCodec();
assertEquals(expected, qpcodec.decode(qpdata));
- String encoded = qpcodec.encode(expected);
+ final String encoded = qpcodec.encode(expected);
assertEquals(expected, qpcodec.decode(encoded));
}
@@ -270,22 +270,22 @@ public class QuotedPrintableCodecTest {
final String qpdata = "If you believe that truth=3Dbeauty, then surely mathematics is the most b=\r\neautiful branch of philosophy.";
final String expected = "If you believe that truth=beauty, then surely mathematics is the most beautiful branch of philosophy.";
- QuotedPrintableCodec qpcodec = new QuotedPrintableCodec(true);
+ final QuotedPrintableCodec qpcodec = new QuotedPrintableCodec(true);
assertEquals(qpdata, qpcodec.encode(expected));
- String decoded = qpcodec.decode(qpdata);
+ final String decoded = qpcodec.decode(qpdata);
assertEquals(qpdata, qpcodec.encode(decoded));
}
@Test
public void testSkipNotEncodedCRLF() throws Exception {
- String qpdata = "CRLF in an\n encoded text should be=20=\r\n\rskipped in the\r decoding.";
- String expected = "CRLF in an encoded text should be skipped in the decoding.";
+ final String qpdata = "CRLF in an\n encoded text should be=20=\r\n\rskipped in the\r decoding.";
+ final String expected = "CRLF in an encoded text should be skipped in the decoding.";
- QuotedPrintableCodec qpcodec = new QuotedPrintableCodec(true);
+ final QuotedPrintableCodec qpcodec = new QuotedPrintableCodec(true);
assertEquals(expected, qpcodec.decode(qpdata));
- String encoded = qpcodec.encode(expected);
+ final String encoded = qpcodec.encode(expected);
assertEquals(expected, qpcodec.decode(encoded));
}